Fix the rendering issue with ssr load #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! You edited a built file though instead of the source code. |
|
Thank you for letting me know. I am a noob in this space. I have rebuilt the package and updated the pull request. Do i need to do anything else? |
|
Encountering the same issue as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this plugin to load the images only when it enters the viewport, which worked fine in non ssr mode. However, when we refreshed the page the images in the viewport was not loaded on first load. It did load when we scrolled back and forth. This issue was seen in the Chrome browser version 77.
I've made some code changes to fix this issue. Request you to review the pull request.