Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added evaluation metrics and visualisation #175

Merged
merged 1 commit into from
May 21, 2024

Conversation

aryan1165
Copy link
Contributor

Related Issue

#171

Description

Added evaluation metrics like f1 score, and auc-roc score, also created visualisations to get insights from these metrics.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshot

Screenshot 2024-05-21 at 6 41 16 PM

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link
Owner

@Akshat111111 Akshat111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why A lot of code has been removed??You should add your contribution and could not entirely remove others work

@aryan1165
Copy link
Contributor Author

I understand, but the only code removed was redundant also some outputs of large dataframe were shrunken, So that notebook is readable easily. Also, I shrunk some code to particular functions and dictionaries following the DRY convention in coding. Should I expand my file again?

Copy link
Owner

@Akshat111111 Akshat111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your work is good and I also agree with your point, but there are some visualizations so include it too then I will merge it.

@Akshat111111 Akshat111111 merged commit ceac60a into Akshat111111:main May 21, 2024
1 check passed
@Akshat111111
Copy link
Owner

your work is good and I also agree with your point, but there are some visualizations so include it too then I will merge it too.Till the time I have merged it

@aryan1165
Copy link
Contributor Author

I have merged those visualisations in one graph only, a histogram graph, in which all parameters are compared in one graph only. It's the same graph. Thanks for merging btw. I can improve these visualisations further.

@Akshat111111
Copy link
Owner

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants