Fix tests for keysight_e4980a #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you pass an initial value this needs to be sent to the instrument the current sim file does not implement this command so an error will be raised
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid initial values for 2 parameters in a group.
Setting the initial value will cause the driver to write to the instrument. This gives an error in the tests since the
yaml file does not implement the relevant command. @Akshita07 If this is really intentional we can instead add this to the yaml file.
Also:
Some small formatting cleanups
Rework fixture such that we don't have to suppress a pylint warning
add a needed get_parser