Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skruuia Wrinkler Bonus to Max Prestige and HC Calculation #131

Closed
5h3i1ah opened this issue Aug 1, 2017 · 8 comments
Closed

Add Skruuia Wrinkler Bonus to Max Prestige and HC Calculation #131

5h3i1ah opened this issue Aug 1, 2017 · 8 comments
Assignees
Labels

Comments

@5h3i1ah
Copy link

5h3i1ah commented Aug 1, 2017

It turns out that when you slot Skruuia in, your Wrinklers instantly have 15% more cookies (assuming Diamond slot), which can have quite an effect on max Prestige.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Aug 1, 2017

It's already there. Are you sure it's not?

@Aktanusa Aktanusa self-assigned this Aug 1, 2017
@5h3i1ah
Copy link
Author

5h3i1ah commented Aug 2, 2017

"The MAX heavenly chips is calculated with the cookies gained from popping all wrinklers [with Skruuia in the diamond Pantheon slot], selling all buildings with Earth Shatterer aura, and buying Chocolate egg"

The bonus is applied retroactively (if you let Wrinklers eat cookies for any amount of time without Skruuia, slotting Skruuia adds 15% cookies to their total). If Cookie Monster does calculate the heavenly chips/prestige with the Skruuia bonus, the tooltip doesn't say.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Aug 2, 2017

Well it was a given via the part of "popping all wrinklers". I've both checked the code and tried it out and the numbers do change when I slot/unslot Skruuia. Are you suggesting I just update the tooltip or does the bonus not change when you slot/unslot Skruuia?

Edit: Maybe I'm misunderstanding and you're suggesting I always calculate with Skruuia on?

@5h3i1ah
Copy link
Author

5h3i1ah commented Aug 2, 2017

I was suggesting you update the tooltip and, if it's not so already, calculate the MAX assuming Skruuia is slotted in diamond.

@Aktanusa
Copy link
Collaborator

Aktanusa commented Aug 2, 2017

Hmm, I can see the problem with max not really max now. The other two Wrinkler sucking upgrades are there or not, which made it easy, but with Gods, you can change on a whim. This is an interesting problem. The same calculation is used to tell you current cookies you'd get from popping all, so I guess the solution is to add on the god bonus to max only if the god is not there already. Okay, I see it as a problem. I'm not sure if this is called a bug or enhancement though, lol.

@5h3i1ah
Copy link
Author

5h3i1ah commented Aug 2, 2017

I think you could make it work like this:

If Skruuia is unslotted (and Pantheon is unlocked), multiply Wrinkler cookies by 1.15 for the calculation.
If Skruuia is in Jade slot, multiply Wrinkler cookies by (1.15/1.05) for the calculation.
If Skruuia is in Ruby slot, multiply Wrinkler cookies by (1.15/1.10) for the calculation.
If Skruuia is in Diamond slot, use current Wrinkler cookies for the calculation.

As for bug or enhancement... I don't know eiher :p

@5h3i1ah 5h3i1ah closed this as completed Aug 2, 2017
@5h3i1ah 5h3i1ah reopened this Aug 2, 2017
@5h3i1ah
Copy link
Author

5h3i1ah commented Aug 2, 2017

Oops, didn't mean to do that.

@Aktanusa
Copy link
Collaborator

Fixed in Version 2.0042.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants