Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brace's ace version is ancient #3

Closed
PurpleMyst opened this issue Jun 11, 2019 · 4 comments · Fixed by #27
Closed

brace's ace version is ancient #3

PurpleMyst opened this issue Jun 11, 2019 · 4 comments · Fixed by #27
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PurpleMyst
Copy link
Collaborator

PurpleMyst commented Jun 11, 2019 •
edited

As per the title, the ace version that brace "browserifies" is ancient. The latest commit is from February 2018, and at the time of writing the date is June 2019. So it's almost a year and a half old.

We could fork brace and set up something (github webhook?) that automatically updates an npm package every time a new commit of ace-builds comes out.

We'll have to toy with this.
@PurpleMyst PurpleMyst added enhancement New feature or request help wanted Extra attention is needed labels Jun 11, 2019
@PurpleMyst
Copy link
Collaborator Author

Trying to switch to ace-builds itself creates wonky behavior, as can be seen in e4d0bfc which caused its revertion in 94694fd

@PurpleMyst
Copy link
Collaborator Author

I think this might be related to ajaxorg/ace-builds#17

@PurpleMyst
Copy link
Collaborator Author

here's an issue comment that seems to outline the steps necessary to depend on ace-builds instead of brace (which is not updated anymore)

ajaxorg/ace#4782

maybe we should add some sort of snapshot test in Jest, like the ones you can use to test React apps

@PurpleMyst PurpleMyst mentioned this issue Sep 1, 2020
Merged
@Akuli Akuli reopened this Sep 2, 2020
@Akuli
Copy link
Owner

Akuli commented Sep 2, 2020

reopening because ajaxorg/ace-builds#27 got reverted

PurpleMyst added a commit that referenced this issue Sep 3, 2020
@PurpleMyst
fix: prevent ^Z in the draw-area undoing in the editor
c666ce4 
pretty much just removes the workaround that used to fix this bug
now ace seems to.. not have the issue that caused the workaround?

only "problem" is closing the drawing area does not re-focus the editor,
but that's not a bugfix for #3. just something to consider.

resolves #3
Akuli pushed a commit that referenced this issue Sep 11, 2020
@PurpleMyst
switch to ace-builds (for real this time) (#28)
9967690 
* fix: switch to ace-builds instead of brace (#27)

* fix: prevent ^Z in the draw-area undoing in the editor

pretty much just removes the workaround that used to fix this bug
now ace seems to.. not have the issue that caused the workaround?

only "problem" is closing the drawing area does not re-focus the editor,
but that's not a bugfix for #3. just something to consider.

resolves #3

* chore: fix indentation

* fix: restore Ctrl-Z workaround, hopefully giving correct behavior on all browsers

this new method should, in theory, be relying on public APIs and not internal behavior, but i'm not sure

hopefully it lasts the test of time :>

* docs: emphasize the headaches the undo code gave us
@Akuli Akuli closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to ace-builds Akuli/mathpaste
2 participants
@Akuli @PurpleMyst