Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM for snow instead of MM #90

Closed
0-5-0 opened this issue Feb 21, 2024 · 12 comments
Closed

CM for snow instead of MM #90

0-5-0 opened this issue Feb 21, 2024 · 12 comments

Comments

@0-5-0
Copy link
Contributor

0-5-0 commented Feb 21, 2024

Would it be possible to display CM for snow instead of MM? Millimeters work great for rain but it seems snow is better represented in centimeters if this data is available from the providers.

@farfromrefug
Copy link
Collaborator

@0-5-0 great idea. Not much snow this days so never really saw that :P will try to find a place to test it with

@0-5-0
Copy link
Contributor Author

0-5-0 commented Feb 22, 2024

Thank you :), I searched a bit for snowy places and found these:

Aomori (JP), Sapporo (JP), Toyama (JP), St. John's Newfoundland (CA), also St. Moritz (CH).

Some have rain coming but hopefully the timing is just right when you have a chance to look at it :P

@farfromrefug
Copy link
Collaborator

@0-5-0 it is now fixed in the new version on github

@0-5-0
Copy link
Contributor Author

0-5-0 commented Feb 22, 2024

I noticed using St. John's Newfoundland as a test, when it's mixed precipitation rain and snow on the same day there's only one icon showing up in the list at the bottom, not one for rain and a second for snow so I think it's adding the mm of rain + cm of snow strangely.

It's showing 19.3mm 100% with the snow icon for St. John's today but looking at the hourly there's a mix of both rain and snow. Not sure if a separate icon for rain and snow would have to be added down in the list?

GFS Global is what I used to test.

@farfromrefug
Copy link
Collaborator

@0-5-0 yes i use only one data. I show the total precipitation (snow+rain). as for the icon it chooses snow if there is some.
Not sure i want to add 2 icons. Uses a lot of space and not add that much. You ll get the details in the hourly view

@0-5-0
Copy link
Contributor Author

0-5-0 commented Feb 22, 2024

Unless one mixed precipitation icon would do in that case?

@farfromrefug
Copy link
Collaborator

you mean having an icon representing precipitation and snow at the same time ?

@0-5-0
Copy link
Contributor Author

0-5-0 commented Feb 22, 2024

Exactly, for days where it's forecasting both rain and snow with a small snow flake and small rain drop maybe in the same icon.

@farfromrefug
Copy link
Collaborator

@0-5-0 ok that i can do. i ll see if i find the right icon

@0-5-0
Copy link
Contributor Author

0-5-0 commented Feb 23, 2024

I tried to find "something" icon wise, just looking for an icon that might show a large snowflake with a large rain drop separated by / ... aside from that I think "sleet" might be a common term but it's always paired with a cloud so might not fit the design.

I found these interesting general icon sets.

https://basmilius.github.io/weather-icons/index-line.html
https://github.com/erikflowers/weather-icons

Other icon examples:

https://fonts.google.com/icons?icon.query=weather+mix&icon.platform=web&icon.set=Material+Symbols
https://pictogrammers.com/library/mdi/
https://icon-sets.iconify.design/?query=snow+rain

@farfromrefug
Copy link
Collaborator

@0-5-0 awesome ! really like the animated weather icons. Might try to add that to the app!
i actually created a new icon. Just need to implement it now
wi-raindrop-snowflake

@0-5-0
Copy link
Contributor Author

0-5-0 commented Feb 24, 2024

The one you made looks perfect, simple and very clear :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants