Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Gradio 3.23 issues #100

Closed
AlUlkesh opened this issue Mar 26, 2023 · 75 comments
Closed

Remaining Gradio 3.23 issues #100

AlUlkesh opened this issue Mar 26, 2023 · 75 comments
Labels
bug Something isn't working

Comments

@AlUlkesh
Copy link
Owner

There currently are still several issues, where the new Gradio version causes weird interactions.

Most of these should be fixed, when the current PRs on the webui's side go through.

I think it would be a waste of time to hunt and fix something until then. Hope that goes faster than PRs did recently.

@mart-hill
Copy link

mart-hill commented Mar 26, 2023

For me, I totally don't see any "send" buttons, just the "folder" one. 🙂

@AlUlkesh
Copy link
Owner Author

That's a bit odd though. It mostly works for me. Do you have the latest commits of both webui and this extension?

Also it seems Firefox is having more touble than Chrome based browsers.

@mart-hill
Copy link

That's a bit odd though. It mostly works for me. Do you have the latest commits of both webui and this extension?

Also it seems Firefox is having more touble than Chrome based browsers.

Yes, both of them are the lastest. "main"/"master" branches. I'm using Edge.
By the way, I still included if v: fix in generation_parameters_copypaste.py file, but now it doesn't matter, because there are no buttons to use. 🙂
By the way, SendTo buttons in PNG Info tab also don't seem to be working - they just switch the tab, and that's it.

@mart-hill
Copy link

For me, it looks like this:
image

I use Adguard as a system-wide ad-filtering software (with their network driver), but "localhost" is excluded from filtering (by me).

@AlUlkesh
Copy link
Owner Author

Can you hit F12 and see if there are any messages in the javascript console about image browser? There are currently many about other parts, those you can ignore at the moment.

@AlUlkesh
Copy link
Owner Author

One other thing, I've noticed the gallery size seems to be a factor. Does changing it to the default 6 x 6 do anything?

@mart-hill
Copy link

mart-hill commented Mar 27, 2023

Drat, I forced return to WebUI's 64b7e8382377bb578d9740c061979776b214cfd9 (before gradio version uplift) commit to be actually able to use it at all... When I started your current version of the extension, I saw the buttons "appearing back" under this old gradio 3.16.2, and AdGuard doesn't stand in the way at all. :)
image

I didn't touch the gallery "size" setting, I think, but I'll check that! It's 6x6, though.
image

Since the programmer is adding more pulls into the WebUI's main repo at this very moment, I'll wait a bit and then test again, on a separate instance (local), but with the same extensions (I have dreambooth [main, 3324b6a], too, so I changed the versions of the modules for WebUI in both req txt files to have them consistent with that extension commit...). 🙂

@forsurefr
Copy link

After pulling the latest commit, these issues still exist:

@AlUlkesh
Copy link
Owner Author

@forsurefr

These Gradio issues really have me scratching my head. I don't mind bugs caused by it or changes I have to make, as long as I can test them. But this Gradio update seems to have left different issues with different people. For example the checkpoint list issue you describe is not happenening for me.

Frustrating.

Anyway, can you hit F12 and see if there are any messages in the javascript console about image browser?

@TheLastCreation
Copy link

TheLastCreation commented Mar 27, 2023

I'm adding this here instead of a new issue since it only came about after pulling the latest in both git repo's
I'm trying to send image to controlnet, also noticing that it starts with controlnet 1 instead of 0.
at first I was getting an error related to line 178, accordion.classList.contains("rotate-90")) being null, adding in a check if null my next error isn't so easy for me debug.

image_browser.js?1679937079.8286097:183
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'classList')
at image_browser_controlnet_send (image_browser.js?167…7079.8286097:183:13)
image_browser_controlnet_send @ image_browser.js?1679937079.8286097:183
await in image_browser_controlnet_send (async)
image_browser_controlnet_send_txt2img @ image_browser.js?1679937079.8286097:199
eval @ VM586:3
ze @ Blocks.svelte:283
(anonymous) @ Blocks.svelte:342
(anonymous) @ index.37b24c07.js:4
zr @ index.37b24c07.js:4
_ @ Button.svelte:12
(anonymous) @ index.37b24c07.js:4
zr @ index.37b24c07.js:4
c @ Button.svelte:11

@Puddz
Copy link

Puddz commented Mar 27, 2023

@forsurefr

These Gradio issues really have me scratching my head. I don't mind bugs caused by it or changes I have to make, as long as I can test them. But this Gradio update seems to have left different issues with different people. For example the checkpoint list issue you describe is not happenening for me.

Frustrating.

Anyway, can you hit F12 and see if there are any messages in the javascript console about image browser?

Hey, I'm having the same kind of issue. When I have this extension enabled, I get a loading symbol for everything basically. All my quick settings at the top and every setting in the settings tab.

This is what shows in the console.
image

@AlUlkesh
Copy link
Owner Author

I just found a couple of issue's with some of webui's javascripts. If noone has done this yet, I'll put in PR.

@AlUlkesh
Copy link
Owner Author

@Puddz
Can you click on the line with deforum? Something in line 20 is not happy there.

@Puddz
Copy link

Puddz commented Mar 27, 2023

@AlUlkesh

Sure. It lead to a .js

function submit_deforum(){
	// alert('Hello, Deforum!')
    rememberGallerySelection('deforum_gallery')
    showSubmitButtons('deforum', false)

    var id = randomId()
    requestProgress(id, gradioApp().getElementById('deforum_gallery_container'), gradioApp().getElementById('deforum_gallery'), function(){
        showSubmitButtons('deforum', true)
    })

    var res = create_submit_args(arguments)

    res[0] = id
	// res[1] = get_tab_index('deforum')

    return res
}

onUiUpdate(function(){
    check_gallery('deforum_gallery')
})

@AlUlkesh
Copy link
Owner Author

Can someone pull my webui PR and check if it also improves some image browser issues?
AUTOMATIC1111/stable-diffusion-webui#9060

@forsurefr
Copy link

forsurefr commented Mar 27, 2023

@forsurefr

These Gradio issues really have me scratching my head. I don't mind bugs caused by it or changes I have to make, as long as I can test them. But this Gradio update seems to have left different issues with different people. For example the checkpoint list issue you describe is not happenening for me.

Frustrating.

Anyway, can you hit F12 and see if there are any messages in the javascript console about image browser?

@AlUlkesh
This is the only error in the console, when interacting with the gallery pages:

Blocks.svelte:214 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'forEach')
    at ct (Blocks.svelte:214:8)
    at Blocks.svelte:293:7

A lot of warnings when loading the UI though ;

runtime.esm.js:15 [svelte-i18n] The message "Unload SD checkpoint to free VRAM" was not found in "en-US", "en".

@Puddz
Copy link

Puddz commented Mar 27, 2023

I also have what @forsurefr has in my console as well. Disabled deforum and looked and that was there.

@AlUlkesh
Copy link
Owner Author

That's been there before the Gradio changes, shouldn't be an issue, For more details see #28.

@AlUlkesh
Copy link
Owner Author

@forsurefr
Can you also go to Settings and check "Image Browser - Print debug logs to the console". Then restart webui and post the complete log, so starting from:

c:\tools\Ai\stable-diffusion-webui>webui-user.bat
venv "c:\tools\Ai\stable-diffusion-webui\venv\Scripts\Python.exe"
Python 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:50:30) [MSC v.1933 64 bit (AMD64)]
Commit hash: 955df7751eef11bb7697e2d77f6b8a6226b21e13

Perhaps we can find another hint there.

@forsurefr
Copy link

With the extension enabled, even the settings page was not loaded so I had to edit config.json.

The only thing that is related to image browser is:

C:\stable-diffusion-webui\extensions\stable-diffusion-webui-images-browser\scripts\image_browser.py
["Name: txt2img / Path: C:\\stable-diffusion-webui\\outputs\\txt2img-images / Base tag: image_browser_tab_txt2img / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: img2img / Path: C:\\stable-diffusion-webui\\outputs\\img2img-images / Base tag: image_browser_tab_img2img / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: txt2img-grids / Path: C:\\stable-diffusion-webui\\outputs\\txt2img-grids / Base tag: image_browser_tab_txt2img-grids / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: img2img-grids / Path: C:\\stable-diffusion-webui\\outputs\\img2img-grids / Base tag: image_browser_tab_img2img-grids / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: Extras / Path: C:\\stable-diffusion-webui\\outputs\\extras-images / Base tag: image_browser_tab_extras / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: Favorites / Path: C:\\stable-diffusion-webui\\log\\images / Base tag: image_browser_tab_favorites / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: Others / Path: C:\\stable-diffusion-webui\\Others / Base tag: image_browser_tab_others / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: Maintenance / Path: C:\\stable-diffusion-webui\\Maintenance / Base tag: image_browser_tab_maintenance / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}", "Name: Maintenance / Path: C:\\stable-diffusion-webui\\Maintenance / Base tag: image_browser_tab_maintenance_1 / Seen base tags: {'txt2img-grids', 'extras', 'maintenance', 'img2img', 'others', 'txt2img', 'favorites', 'maintenance_1', 'img2img-grids'}"]

These are the image browser settings:

"image_browser_preload": false,
"image_browser_delete_message": true,
"image_browser_page_columns": 10.0,
"image_browser_page_rows": 10.0,
"image_browser_pages_perload": 5.0,
"image_browser_with_subdirs": true,
"image_browser_copy_image": false,
"image_browser_txt_files": true,
"image_browser_logger_warning": false,
"image_browser_logger_debug": true,
"image_browser_delete_recycle": false,
"image_browser_scan_exif": true,
"image_browser_mod_shift": false,
"image_browser_mod_ctrl_shift": false,
"image_browser_active_tabs": "txt2img, img2img, txt2img-grids, img2img-grids, Extras, Favorites, Others, Maintenance",
"image_browser_enable_maint": true,
"image_browser_hidden_components": [],
"image_browser_ranking_pnginfo": false,

@AlUlkesh
Copy link
Owner Author

Which OS, web browser, python version are you using?

@wmooring
Copy link

wmooring commented Mar 27, 2023

So, I found out on my fresh SD install that I originally did to fix an issue with the preview images not loading on the main tab, that if the "https://github.com/AlUlkesh/stable-diffusion-webui-images-browser.git" extension is enabled, the Checkpoint dropdown at the top and the contents Settings tab will never load, the "spinning orange boxes" loading icons just stay. Disabling the extension, restarting the UI, and then reloading the browser tab will allow the settings to show up again. The tab reload doesn't help as long as the extension is enabled.

However, I found out this issue affects desktop Firefox but not desktop Chrome. Mobile Chrome and Firefox also have the issue. Which is a shame, because I kind of need the extension to use SD from my phone, since I can't browse my desktop folders from it effectively.

Windows 10 Pro and an Android phone, Image Browser extension is version a9032d4 (Mon Mar 27 14:14:06 2023)

The status bar of the bottom of my UI:
python: 3.10.6  •  torch: 1.13.1+cu117  •  xformers: N/A  •  gradio: 3.23.0  •  commit: 955df775  •  checkpoint: 6ce0161689

@forsurefr
Copy link

So, I found out on my fresh SD install that I originally did to fix an issue with the preview images not loading on the main tab, that if the "https://github.com/AlUlkesh/stable-diffusion-webui-images-browser.git" extension is enabled, the Checkpoint dropdown at the top and the contents Settings tab will never load, the "spinning orange boxes" loading icons just stay. Disabling the extension, restarting the UI, and then reloading the browser tab will allow the settings to show up again. The tab reload doesn't help as long as the extension is enabled.

However, I found out this issue affects desktop Firefox but not desktop Chrome. Mobile Chrome and Firefox also have the issue. Which is a shame, because I kind of need the extension to use SD from my phone, since I can't browse my desktop folders from it effectively.

Windows 10 Pro and an Android phone, Image Browser extension is version a9032d4 (Mon Mar 27 14:14:06 2023)

The status bar of the bottom of my UI: python: 3.10.6  •  torch: 1.13.1+cu117  •  xformers: N/A  •  gradio: 3.23.0  •  commit: 955df775  •  checkpoint: 6ce0161689

My setup is the same but using Brave on desktop. Have not tried Chrome or Firefox.

@AlUlkesh
Copy link
Owner Author

I just tried Chrome, Firefox and Brave, but they all do not have this issue for me (Win 10).

I suggest you try the PR I quoted above, I think that solves a lot of issues.

@MrKuenning
Copy link

You Rock!

@horribleCodes
Copy link

It looks like the "Send to" buttons are missing when using the image browser from a mobile device.

@MrKuenning
Copy link

Screenshot_20230408-021844.png

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented Apr 8, 2023

@horribleCodes
Works on my android. Anything on the javascript console?

@GeorgLegato
Copy link

GeorgLegato commented Apr 9, 2023

Hi, I fixed for my extension (VectorStudio) the sendtoControlnet today.
The official codebase as of today was still not compat with gradio 3.23

here the code snippet for the function "image_browser_controlnet_send"
(skipping the data-img stuff....)


	const container = gradioApp().querySelector(toTab === "txt2img" ? "#txt2img_script_container" : "#img2img_script_container")

	const accordion = container.querySelector("#controlnet .label-wrap")
	if (!accordion.classList.contains("open")) accordion.click()  // on first time no DOM there!
	
	const tab = gradioApp().querySelectorAll("#tab_"+toTab+" #controlnet .tab-nav button")[controlnetNum]
	if (!tab) {
		// come back after click() has created the DOM 
		setTimeout(()=>{
			vectorstudio_controlnet_send(toTab,controlnetNum)
		},1000)
		return
	}

	if (!tab.classList.contains("selected")) tab.click()

	const input = gradioApp().querySelectorAll("#tab_"+toTab+" #controlnet input[type='file']")[controlnetNum]
	/*  try {
			a click seems not to be neccessary 
			input.parentElement.click()
		} catch (e) {}
	*/

	input.value = ""
	input.files = dt.files
	input.dispatchEvent(new Event("change", { bubbles: true, composed: true }))

	// switch to txt2/img2img and scroll to controlnet-tab
	vectorstudio_gototab(toTab, "tabs", tab)

on initial load the click()-method have a race condition if not per design a glitch. the click on tab does create the DOM, which is done defered. So I add a timeout after click() and come back to the same routine try to handle it, now.

replace "vectorstudio_" to imagebrowser of course.

Full code here
https://github.com/GeorgLegato/stable-diffusion-webui-vectorstudio/blob/c428f4b420910c217924334dbdb964d46e20d9e9/javascript/vectorstudio-ext.js#L74

@horribleCodes
Copy link

@horribleCodes Works on my android. Anything on the javascript console?

Honestly at this point nothing about the extension is doing anything on my tablet. I'm not getting any log messages at all, even with all logging enabled - it's working fine on my PC.
The WebUI feels much slower and less responsive on my tablet overall, so I'm not sure what exactly is going on - but I'm definitely noticing the lack of any form of response from the image browser.

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented Apr 9, 2023

@horribleCodes
That is truly odd. If you enabled the image browser debug logging, you should at the very least get the initial logs:

logger.debug(f"{sys.executable} {sys.version}")

This code is executed at the very beginning, before any ui is even created.

If you don't even get that, that would probably mean, the script is not being loaded (correctly) by webui. But then that should be on your console.

I'm a little lost here.

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented Apr 9, 2023

Can anyone who still has issues please follow the new debug info guide: #130 and post your logs?

@horribleCodes
Copy link

Can anyone who still has issues please follow the new debug info guide: #130 and post your logs?

Okay, even at log level 3 my tablet isn't triggering any log messages, even though it works fine on my PC. However, that was on Brave, and when I tried 2 different Chromium browsers, the images loaded. However, one refused to load the EXIF data, and both still aren't showing the "Send To"-buttons. Here's what I get when I loaded the first page and selected an image:

2023-04-10-22:49:24 image_browser.py: get_image_page
2023-04-10-22:49:24 image_browser.py: get_all_images
2023-04-10-22:49:24 image_browser.py: curr_path: ...\stable-diffusion-webui\outputs\txt2img-images
2023-04-10-22:49:24 image_browser.py: cache_exif: 41/5100 cache_aes: 41/5100 0.2 seconds
2023-04-10-22:49:24 image_browser.py: get_image_thumbnail
2023-04-10-22:51:51 image_browser.py: show_image_info: tab_base_tag_box, num, page_index, len(filenames), num_of_imgs_per_page: image_browser_tab_txt2img, 23, 1.0, 5100, 36
2023-04-10-22:55:56 image_browser.py: get_image_page
2023-04-10-22:55:56 image_browser.py: get_all_images
2023-04-10-22:55:56 image_browser.py: curr_path: ...\stable-diffusion-webui\outputs\txt2img-images
2023-04-10-22:55:56 image_browser.py: cache_exif: 0/5100 cache_aes: 0/5100 0.0 seconds
2023-04-10-22:55:56 image_browser.py: get_image_thumbnail
2023-04-10-22:56:05 image_browser.py: show_image_info: tab_base_tag_box, num, page_index, len(filenames), num_of_imgs_per_page: image_browser_tab_txt2img, 23, 1.0, 5100, 36
2023-04-10-22:56:21 image_browser.py: show_image_info: tab_base_tag_box, num, page_index, len(filenames), num_of_imgs_per_page: image_browser_tab_txt2img, 24, 1.0, 5100, 36

@AlUlkesh
Copy link
Owner Author

Can you all try the latest update please: #135

@Kapowpenguin1
Copy link

Kapowpenguin1 commented Apr 13, 2023

unsure if this is a bug or just a feature that's yet to be migrated from prior to 3.23, but i've found that

  1. I can no longer zoom into images. I can view the gallery, and click on an image to open it, but i used to be able to click on it again to open a larger view. I can no longer do that. instead, it simply advances to the next image
  2. image metadata is no longer being displayed. prior to 3.23, clicking on an image would load all its metadata into the boxes on the right. now, the boxes instead stay empty

if these are indeed bugs, i will submit debug logs

edit: nevermind...? ig i'm just on an outdated version... i installed image browser on a fresh install of the webui and everything works perfectly. now to... figure out how to get the webui to acknowledge the latest version
edit 2: i'm very confused. the fresh install doesn't face either problem, but the updated image browser [i just ran git pull in the extension directory] in my original install still faces problem 1...

@AlUlkesh
Copy link
Owner Author

The first issue is a webui issue. I actually have submitted a PR to fix that. But it's been waiting for weeks to get merged by now. Check the third point here: #107

You might want to install that manually and try it out.

@Kapowpenguin1
Copy link

The first issue is a webui issue. I actually have submitted a PR to fix that. But it's been waiting for weeks to get merged by now. Check the third point here: #107

You might want to install that manually and try it out.

how would i do a manual install? am i supposed to git clone your repo into my webui directory?

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented Apr 13, 2023

There are several ways to do it. The cleanest would probably be to create a local branch like this:

git fetch origin pull/9060/head:pr9060
git checkout pr9060

If you want to switch back to the master branch later, do:

git checkout master

@Kapowpenguin1
Copy link

There are several ways to do it. The cleanest would probably be to create a local branch like this:

git fetch origin pull/9060/head:pr9060
git checkout pr9060

If you want to switch back to the master branch later, do:

git checkout master

thanks- 9060 was successfully able to fix the zoom issue. ig i just wait for it to be merged, now

@Blargswell
Copy link

unsure if this is a bug or just a feature that's yet to be migrated from prior to 3.23, but i've found that

  1. I can no longer zoom into images. I can view the gallery, and click on an image to open it, but i used to be able to click on it again to open a larger view. I can no longer do that. instead, it simply advances to the next image
  2. image metadata is no longer being displayed. prior to 3.23, clicking on an image would load all its metadata into the boxes on the right. now, the boxes instead stay empty

if these are indeed bugs, i will submit debug logs

edit: nevermind...? ig i'm just on an outdated version... i installed image browser on a fresh install of the webui and everything works perfectly. now to... figure out how to get the webui to acknowledge the latest version edit 2: i'm very confused. the fresh install doesn't face either problem, but the updated image browser [i just ran git pull in the extension directory] in my original install still faces problem 1...

I was having the same problem, but thanks to someone else bringing it up, the issue was being caused by my Open Pose extension (for some reason) being stuck on an outdated version. Every time I tried to update it from the UI, it would just stay out of date. I had to delete it and reinstall it fresh to get it up to date, but once that was done, all of my problems in the image browser went away.

@Kapowpenguin1
Copy link

unsure if this is a bug or just a feature that's yet to be migrated from prior to 3.23, but i've found that

  1. I can no longer zoom into images. I can view the gallery, and click on an image to open it, but i used to be able to click on it again to open a larger view. I can no longer do that. instead, it simply advances to the next image
  2. image metadata is no longer being displayed. prior to 3.23, clicking on an image would load all its metadata into the boxes on the right. now, the boxes instead stay empty

if these are indeed bugs, i will submit debug logs
edit: nevermind...? ig i'm just on an outdated version... i installed image browser on a fresh install of the webui and everything works perfectly. now to... figure out how to get the webui to acknowledge the latest version edit 2: i'm very confused. the fresh install doesn't face either problem, but the updated image browser [i just ran git pull in the extension directory] in my original install still faces problem 1...

I was having the same problem, but thanks to someone else bringing it up, the issue was being caused by my Open Pose extension (for some reason) being stuck on an outdated version. Every time I tried to update it from the UI, it would just stay out of date. I had to delete it and reinstall it fresh to get it up to date, but once that was done, all of my problems in the image browser went away.

so i did what you mentioned, switched back to the master branch, then ran git pull in the openpose-editor directory, and restarted the webui. and voila, image zoom and descriptions work properly now. very interesting

@GeorgLegato
Copy link

unsure if this is a bug or just a feature that's yet to be migrated from prior to 3.23, but i've found that

  1. I can no longer zoom into images. I can view the gallery, and click on an image to open it, but i used to be able to click on it again to open a larger view. I can no longer do that. instead, it simply advances to the next image
  2. image metadata is no longer being displayed. prior to 3.23, clicking on an image would load all its metadata into the boxes on the right. now, the boxes instead stay empty

if these are indeed bugs, i will submit debug logs
edit: nevermind...? ig i'm just on an outdated version... i installed image browser on a fresh install of the webui and everything works perfectly. now to... figure out how to get the webui to acknowledge the latest version edit 2: i'm very confused. the fresh install doesn't face either problem, but the updated image browser [i just ran git pull in the extension directory] in my original install still faces problem 1...

I was having the same problem, but thanks to someone else bringing it up, the issue was being caused by my Open Pose extension (for some reason) being stuck on an outdated version. Every time I tried to update it from the UI, it would just stay out of date. I had to delete it and reinstall it fresh to get it up to date, but once that was done, all of my problems in the image browser went away.

so i did what you mentioned, switched back to the master branch, then ran git pull in the openpose-editor directory, and restarted the webui. and voila, image zoom and descriptions work properly now. very interesting

I do not switch from any other branch to main or so, my experience is the bug is sporadic: sometimes i can open a small preview in details view (zoom view) and sometimes not.

@Kapowpenguin1
Copy link

sure, i just mention that i switched from the master branch bc i previously was on pr9060 to fix the issue

@GeorgLegato
Copy link

GeorgLegato commented Apr 15, 2023

found something about the "Cant see zoomed image" bug:
I try to open 10 times an image.. no success, no zommed winows opened.
In that moment I open the debug dev-tools in my Edge, I can open any image and zoomed view.
Is there a timing/sync problem, which is impacted by debugging, slower execution time due to dev-tools on?

image only zoomed view when dev-tools on

image

@AlUlkesh
Copy link
Owner Author

It's possible. I also have had another bug where the issue goes away if you make your browser window smaller, which would also be true in your case with devtools taking up a lot of the space.

Have you tried the PR I mentioned above to see if the problem goes away?

@JoeyLearnsToCode
Copy link

I don’t know if it’s related to this issue. The front-end performance of the image browser is particularly poor in the latest version of webui (of course, the front-end performance of the latest version of webui is not good). I know it’s related to Gradio. Almost every operation requires waiting for Gradio’s animation. In the image browser, I like to click and operate very quickly. Now I can’t use it smoothly.

不知道和这个issue有没有关系,image browser 在最新版本的 webui 中前端性能格外差(当然,最新版本 webui 的前端性能本来也不好),我知道和 gradio 有关系,几乎每个操作后都要等 gradio 的动画,在 image browser 中我喜欢很迅速地点击、操作,现在我不能很流畅地使用了。

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented May 6, 2023

@JoeyLearnsToCode
When I first switched to the new Gradio I also noticed a massive slowdown. However, in my case, I realized it was because my system RAM was filling out and it started swapping out to the SSD. Once I got more RAM it was fine.

So perhaps, you can check, how your system's status is, when those slowdowns happen?

@JoeyLearnsToCode
Copy link

@AlUlkesh thank you for reply, my RAM capacity is 32GB, that should not be the reason in my case.
For example, when I use left/right key switch image, two loading animations show above the image, that is where "Current ranking" and "Set ranking to" locate. The animations exist 0.2~0.3s, it's not too long, but I just can't stand it, maybe I'm being picky.
In the old version of webui, there is no loading animation. Now, feels like these animations are keep telling me, "you are using a remote service by internet, instead of a local web app", but I am using a local web app! :(

AlUlkesh added a commit that referenced this issue May 6, 2023
@AlUlkesh
Copy link
Owner Author

AlUlkesh commented May 6, 2023

@JoeyLearnsToCode
So you think it's more a perceived delay than an actual one? Hmm... I just added the option to turn the progress indicator off. Check if this feels better for you.
image

@JoeyLearnsToCode
Copy link

@AlUlkesh wow, much better!
But now I find another problem, the "Generation Info" part update with 1s delay after switching image(which is realtime and fast).
Within that second of delay, delete button seems to delete the previous image(before switch), not the new one(after).

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented May 6, 2023

@JoeyLearnsToCode Let's look at this issue here: #159

@AlUlkesh AlUlkesh unpinned this issue May 8, 2023
@AlUlkesh AlUlkesh closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests