-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
I added msg.query to the code to use predefined queries. (#19)
msg.topic never used in the code but the readMe says it can hold SQL queries. I replaced topic with query because topic used several time in other nodes. Co-authored-by: Mathias Rangel Wulff <m@rawu.dk>
- Loading branch information
1 parent
e7cec71
commit 4e9ac45
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e9ac45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened here? Why the change? Why duplicating solution for the same use case? msg.query is doing same thing as msg.topic.
Now you can pass query via msq.topic and msq.query, additionaly you erased info in docs about msg.topic...
Please, undo this commit.
4e9ac45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamgaborgithub any inputs regarding the feedback from @tmdoit ?
4e9ac45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamgaborgithub ?!?