Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The button doesn't fill the full screen size #16

Closed
volkoivan opened this issue Apr 2, 2018 · 5 comments
Closed

The button doesn't fill the full screen size #16

volkoivan opened this issue Apr 2, 2018 · 5 comments

Comments

@volkoivan
Copy link

You can see at the image the size of the button once it finished it's stop animation.

2018-04-02 15 45 56

Here it's original layout:
2018-04-02 15 47 55

Is it me doing something wrong, or is it the problem with the library?

@AladinWay
Copy link
Owner

Thank you for reporting the issue. Can you reproduce it in the example project ? which device/simulator did you use for testing ?

@volkoivan
Copy link
Author

volkoivan commented Apr 4, 2018

Simulator iPhone8 Plus
To reproduce it remove the leading constraint of the button so it becomes a circle
Then you'll notice a gap on the left top corner after stopLoading call

@AladinWay
Copy link
Owner

@megavirus74 in file TransitionButton.swift line 190 you can increase the expand value:
expandAnim.toValue = 26.0
Maybe It should be an optional property when choosing expand animation or a button property. I will think about that and update the library if needed. Note that usually while expanding you will have a fade animation of the next screen, so it should not be a problem if the button does not expand fully, but that depends of the user needs, I may update add it as property. Thank you for reporting and using the library.

@volkoivan
Copy link
Author

I'm using it as a pod, so changing it in code will be a little messy, but okay if there is no workaround for now
Maybe make it based on the button position and size compared to view size?
Anyway, thanks for help!

@AladinWay
Copy link
Owner

@megavirus74 It's fixed now, sorry for the delay. It will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants