Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade support to Swift 4.2 #26

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Upgrade support to Swift 4.2 #26

merged 3 commits into from
Sep 18, 2018

Conversation

cuzv
Copy link
Contributor

@cuzv cuzv commented Sep 18, 2018

No description provided.

@AladinWay
Copy link
Owner

Thank you for your pull request, can you please update the .travis.yml file as well to build it with xcode10 and iOS 12, because now it fails on the CI server

@AladinWay
Copy link
Owner

Thank you for the update, but I can see that it's still failing because of the wrong device id, can you please update it with the id 68C8AF87-EE3A-4D82-9266-0730B612D721 and hopefully it works now

@cuzv
Copy link
Contributor Author

cuzv commented Sep 18, 2018

Sorry for the wrong simulator id issue. now the check passed. :]

@AladinWay AladinWay merged commit 8f2b4f2 into AladinWay:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants