Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where spinner isn't updated when button's frame is updated #9

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

j55blanchet
Copy link
Contributor

I found this bug when trying to create a TransitionButton with one rect, then added it to a stackView. The stackView updated the frame of the button, but the spinner's frame wasn't updated, causing it to become un-centered

@richardtop
Copy link

@j55blanchet nice fix, it helps also when TransitionButton is used without Storyboards, but with AutoLayout.
In the aforementioned case, the frame of the TransitionButton is zero just after the initialization. It is being set later, after application of AutoLayout constraints.

@AladinWay
Copy link
Owner

Thank you for your contribution. I will take a look into that and merge it if needed ;)

@j55blanchet
Copy link
Contributor Author

j55blanchet commented Dec 7, 2017 via email

@AladinWay AladinWay merged commit f09a595 into AladinWay:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants