Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme fix DataResponse #1760

Merged
merged 1 commit into from Nov 12, 2016
Merged

Readme fix DataResponse #1760

merged 1 commit into from Nov 12, 2016

Conversation

julien-c
Copy link
Contributor

@julien-c julien-c commented Nov 7, 2016

No description provided.

@cnoon
Copy link
Member

cnoon commented Nov 12, 2016

Thanks @julien-c! 🍻

@cnoon cnoon merged commit 1495824 into Alamofire:master Nov 12, 2016
@cnoon cnoon added this to the 4.1.0 milestone Nov 12, 2016
@cnoon cnoon self-assigned this Nov 12, 2016
soujyunshibata pushed a commit to soujyunshibata/Alamofire that referenced this pull request Nov 17, 2016
* commit 'c2134d7645ee6869298dc8d3587e580a3ec83f96': (24 commits)
  Added release notes to the CHANGELOG and bumped the version to 4.1.0.
  Updated the README and AF4 Migration Guide requirements.
  Updated podspec deployment targets to match the project.
  Updated the iOS Example app deployment target to iOS 8.0.
  Updated the Travis CI yaml file to support Xcode 8.1 and iOS 8.
  Dropped deployment targets to iOS 8.0 and macOS 10.10 for upcoming release.
  Fixed issue in TLS tests where root certificate is missing from server trust.
  Session manager now cleans up temp multipart form data file after upload.
  Updated test framework names in iOS Example app since Xcode insisted.
  Removed explicit `String.Encode` declaration where the type is implied.
  Switched AdaptError extraction over to optional underlyingAdaptError property.
  Retrier is now called when uploads encounter adapt error.
  Retrier is now called when downloads encounter adapt error.
  Added test verifying retrier is called when request encounters adapt error.
  Throwing an error in adapter now calls retrier to check whether or not to retry.
  [PR Alamofire#1723] Refactored download completion to not crash on nil response.
  Removed excess whitespace from the project…no functional changes.
  Disabled auto-code signing on macOS and removed duplicate code signing identities.
  [PR Alamofire#1735] Fixed Xcode 8.1 compiler warnings and project suggestions.
  [PR Alamofire#1760] Fixed incorrect response type in the response README examples.
  ...

# Conflicts:
#	Alamofire.xcodeproj/project.pbxproj
#	Source/SessionDelegate.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants