New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README example in the "POST Request with Parameters" section #1984

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
2 participants
@pbartolome
Contributor

pbartolome commented Feb 25, 2017

In the README.md the usage example for POST Request with Parameters doesn't include the parameter method: .post.

If the method is not included in the request it will default to .get

@cnoon cnoon self-requested a review Feb 26, 2017

@cnoon cnoon self-assigned this Feb 26, 2017

@cnoon

cnoon approved these changes Feb 26, 2017

Looks good to me!

@cnoon

This comment has been minimized.

Show comment
Hide comment
@cnoon

cnoon Feb 26, 2017

Member

Good catch here @pbartolome...thanks for putting this together! 🍻

Member

cnoon commented Feb 26, 2017

Good catch here @pbartolome...thanks for putting this together! 🍻

@cnoon cnoon merged commit ef8b1fd into Alamofire:master Feb 26, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@cnoon cnoon added this to the 4.4.0 milestone Feb 26, 2017

looseyi added a commit to looseyi/Alamofire that referenced this pull request May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment