Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README example in the "POST Request with Parameters" section #1984

Merged
merged 1 commit into from Feb 26, 2017
Merged

Fix README example in the "POST Request with Parameters" section #1984

merged 1 commit into from Feb 26, 2017

Conversation

pbartolome
Copy link
Contributor

@pbartolome pbartolome commented Feb 25, 2017 •
edited

In the README.md the usage example for POST Request with Parameters doesn't include the parameter method: .post.

If the method is not included in the request it will default to .get

@cnoon cnoon self-requested a review February 26, 2017 16:26
@cnoon cnoon self-assigned this Feb 26, 2017
cnoon
cnoon approved these changes Feb 26, 2017
View reviewed changes
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cnoon
Copy link
Member

cnoon commented Feb 26, 2017

Good catch here @pbartolome...thanks for putting this together! 🍻

@cnoon cnoon merged commit ef8b1fd into Alamofire:master Feb 26, 2017
@cnoon cnoon added this to the 4.4.0 milestone Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnoon cnoon cnoon approved these changes

Assignees

@cnoon cnoon

Labels
bug documentation
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pbartolome @cnoon