New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2052 - Change reachability computation #2060

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@MarcoSantarossa
Contributor

MarcoSantarossa commented Apr 3, 2017

It fixes the issue #2052. There is a bug with the reachability computation when the user has a sim but s/he didn't select the carrier yet. In this scenario we have both .connectionRequired and .isWWAN.

Show outdated Hide outdated Source/NetworkReachabilityManager.swift Outdated
Show outdated Hide outdated Source/NetworkReachabilityManager.swift Outdated
@MarcoSantarossa

This comment has been minimized.

Show comment
Hide comment
@MarcoSantarossa

MarcoSantarossa Apr 14, 2017

Contributor

I think CI for watchOS has some issues @jshier

Contributor

MarcoSantarossa commented Apr 14, 2017

I think CI for watchOS has some issues @jshier

@MarcoSantarossa

This comment has been minimized.

Show comment
Hide comment
@MarcoSantarossa

MarcoSantarossa May 2, 2017

Contributor

@jshier can you rerun the tests please? They pass locally so it seems an odd failure.

Contributor

MarcoSantarossa commented May 2, 2017

@jshier can you rerun the tests please? They pass locally so it seems an odd failure.

@jshier

This comment has been minimized.

Show comment
Hide comment
@jshier

jshier May 2, 2017

Contributor

No problem, it's a Travis issue (still).

Contributor

jshier commented May 2, 2017

No problem, it's a Travis issue (still).

@MarcoSantarossa

This comment has been minimized.

Show comment
Hide comment
@MarcoSantarossa

MarcoSantarossa May 25, 2017

Contributor

@jshier is this PR under review? Or Don't you want it merged?

Contributor

MarcoSantarossa commented May 25, 2017

@jshier is this PR under review? Or Don't you want it merged?

@jshier

This comment has been minimized.

Show comment
Hide comment
@jshier

jshier May 29, 2017

Contributor

@MarcoSantarossa We're still reviewing changes for our 4.5 release, we'll likely review and merge soon.

Contributor

jshier commented May 29, 2017

@MarcoSantarossa We're still reviewing changes for our 4.5 release, we'll likely review and merge soon.

cnoon added a commit that referenced this pull request Jun 16, 2017

[PR #2060] Updated reachability to support [.connectionRequired, .isW…
…WAN] combo.

These changes resolve issue #2052 where the reachability calcuation was incorrectly reporting the connection as reachable. When a user has install a simcard, but hasn’t yet selected a carrier, the connection is not reachable.
@cnoon

This comment has been minimized.

Show comment
Hide comment
@cnoon

cnoon Jun 16, 2017

Member

Thanks for putting this together @MarcoSantarossa...much appreciated! 🍻 I've made a few small tweaks to your PR and have pushed it into master in 68f4eb3 while maintaining your attribution. This change will go out shortly in the AF 4.5 release.

Thanks again!

Member

cnoon commented Jun 16, 2017

Thanks for putting this together @MarcoSantarossa...much appreciated! 🍻 I've made a few small tweaks to your PR and have pushed it into master in 68f4eb3 while maintaining your attribution. This change will go out shortly in the AF 4.5 release.

Thanks again!

@cnoon cnoon closed this Jun 16, 2017

@cnoon cnoon added this to the 4.5.0 milestone Jun 16, 2017

@cnoon cnoon self-assigned this Jun 16, 2017

@cnoon cnoon added the reachability label Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment