[AF4]: Hotfix project updates for Xcode 10.2 #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnoon
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR updates the AF4 project for Xcode 10.2 requirements, in preparation for a final release.
Implementation Details 🚧
Ran the Swift 5 updates for all targets, fixed some tests.
Testing Details 🔍
Tests which had an implicit dependency on the ordering of items in a dictionary were broken in Xcode 10.2, so I made them data count comparisons instead.
The user agent test was also broken due to changes in the detected system while running tests, so made some
containstests instead as a workaround.