Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AF4]: Hotfix project updates for Xcode 10.2 #2767

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@jshier
Copy link
Contributor

commented Mar 27, 2019

Goals ⚽️

This PR updates the AF4 project for Xcode 10.2 requirements, in preparation for a final release.

Implementation Details 🚧

Ran the Swift 5 updates for all targets, fixed some tests.

Testing Details 🔍

Tests which had an implicit dependency on the ordering of items in a dictionary were broken in Xcode 10.2, so I made them data count comparisons instead.

The user agent test was also broken due to changes in the detected system while running tests, so made some contains tests instead as a workaround.

@cnoon

cnoon approved these changes Mar 27, 2019

Copy link
Member

left a comment

Looks good to me. It might be good to try and fix the multipart form data tests in a bit more robust way in AF5. This works fine though for 4.x IMO.

@cnoon cnoon self-assigned this Mar 27, 2019

@cnoon cnoon added this to the 4.8.2 milestone Mar 27, 2019

@cnoon cnoon merged commit 568cde8 into hotfix Mar 27, 2019

@cnoon cnoon deleted the af4-xcode-10.2 branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.