Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR restores Swift 5 support by removing
@dynamicMemberLookup
fromAlamofireExtension
.This PR also brings the project into sync with AFI's SwiftFormat config.
Implementation Details 🚧
Turns out the
KeyPath
version of the@dynamicMemberLookup
requirement is only available on Swift 5.1+, so it needed to be removed in general. There was also an implicit return but that was removed along with the subscript.Testing Details 🔍
Unfortunately GitHub Actions don't have Xcode 10.3 available, so I had to reinstall it and build locally.