Remove file URL error, add support for downloads #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3332
Goals ⚽
Turns out some people do use local file URLs for testing and such, so this PR removes the previous error and fixes
DownloadRequestto properly support downloaded files.Implementation Details 🚧
The only code changes are in
DownloadRequestsince it previously required anHTTPURLResponseto generate the file location on disk. UnfortunatelyURLSessionDownloadTaskdoesn't treat a fileURLdownload in any special way, so it just copies the file to the temp directory. Alamofire then moves that file to a new name so it survives theURLSessioncleanup.Testing Details 🔍
Previously added tests have been updated to now succeed with file
URLs.