Xcode 13 Support #3486
Merged
Xcode 13 Support #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlcvp
reviewed
Sep 9, 2021
Source/Combine.swift
Outdated
| @@ -22,7 +22,7 @@ | |||
| // THE SOFTWARE. | |||
| // | |||
|
|
|||
| #if canImport(Combine) | |||
| #if !(os(iOS) && (arch(i386) || arch(arm))) | |||
There was a problem hiding this comment.
this check must be broader to check for windows and linux that doesn't support Combine framework
Tests/CombineTests.swift
Outdated
| @@ -22,7 +22,7 @@ | |||
| // THE SOFTWARE. | |||
| // | |||
|
|
|||
| #if canImport(Combine) | |||
| #if !(os(iOS) && (arch(i386) || arch(arm))) | |||
jshier
added a commit
that referenced
this pull request
Jan 15, 2022
* Update for Xcode 13, workaround Combine issues. * Disable Combine on Windows and Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3481
Goals ⚽
This PR tracks changes necessary for Xcode 13. It also adds a workaround for Combine-related build issues by limiting Combine features to 64-bit platforms as well as the ability to import Combine.
Implementation Details 🚧
No functional changes, just deployment targets.
Testing Details 🔍
No new tests.