[String Response] Respect remote server's content encoding #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
changed the title
mattt
added a commit
that referenced
this pull request
Apr 9, 2015
|
Thanks for your PR, @kylef. I really appreciate you following up on #358 to find the underlying problem here. We should definitely respect the server's character encoding, when provided. We should definitely follow the spec to use ISO-8859-1 by default. However, we should also provide a way to override this behavior for when the server is doing something wrong, and it's not possible to fix. I implemented this with 6cffddc, which should resolve the original issues. Let me know if I missed anything here. Thanks again, @kylef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always follow the content encoding sent from the server instead of assuming UTF-8 or whatever the user has configured.
Note,
iso-8859-1is the default encoding for HTTP 1.1. As such that is the default if a server didn't explicitly set it to utf-8.