Add Separate Response Hooks #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3401
Goals ⚽
This PR adds
onHTTPResponseclosure hooks toDataRequest/UploadRequestandDataStreamRequestto enable the cancellation of requests before data is transferred, requests that need to check response info for later parsing, or peculiar requests that may trigger multiple response callbacks, like MJPEG streams.Implementation Details 🚧
Like the other value hooks, this API accepts a single closure. The only unique bit here is that there's second, disfavored, version of the API that allows the user to return
ResponseDispositionvalue to cancel or end the request without the body.Testing Details 🔍
Streaming tests are being updated to check these events always fire before the other events. More tests are needed around cancellation or ending behavior to ensure that's really possible.