Split Project into Multiple Swift Files #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Source/Alamofire.swift
# Conflicts: # Source/Alamofire.swift
|
This looks great, @cnoon. Thanks so much for taking the time to refactor things into something a bit more understandable for anyone less familiar with the library. |
mattt
added a commit
that referenced
this pull request
May 11, 2015
Split Project into Multiple Swift Files
|
@cnoon Really nice work! Thanks! |
|
hi, can you tell me the way to get your pr? im new in github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the project up into multiple Swift files separated into
CoreandFeaturesgroups. I was very careful to split each major change into a separate commit so we didn't lose any of the critical ACL changes that were required.I also took a stab at reworking some of the MARK statements to attempt to make it as easy as possible to quickly find the section you are looking for. I think it turned out pretty well, but I really would love some additional feedback if something doesn't seem quite right.
I also found some other minor things that I'd like to switch up, but I filed separate cards in Trello for each of them. That way this PR focuses only on the task at hand 👍🏻