Only set cookies in debugPrintable when relevant #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If HTTPShouldSetCookies is set to false in the session's config then any cookies set will not be sent as part of the request. Previously the cURL command output would include cookies whether or not HTTPShouldSetCookies was true or not. This commit will only print cookies in the cURL output if they'll actually be sent.
|
Great! Thanks @cnoon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
HTTPShouldSetCookiesis set tofalsein the session's config then any cookies set will not be sent as part of the request.Previously the cURL command output provided by
debugPrintln()would include cookies whether or notHTTPShouldSetCookieswas true or false. This commit will make it sodebugPrintln()only prints cookies in the cURL output if they'll actually be sent.