Feature - Network Activity Indicator #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jshier, @kcharwood, @kylef for review |
|
Once we get this through, I'll create all the documentation and get the repo opened up so I can start testing with Travis. |
|
Pod spec? |
|
I'm on it @jshier. 👍🏼 |
|
Podspec is up but won't build until Alamofire 3.2.0 is released. |
| @@ -0,0 +1 @@ | |||
| github "Alamofire/Alamofire" "master" | |||
There was a problem hiding this comment.
This will be repointed at ~> 3.2 once it is actually released.
cnoon
added a commit
that referenced
this pull request
Feb 8, 2016
Feature - Network Activity Indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
NetworkActivityIndicatorManagerclass and all the tests to verify behavior. Code coverage is currently at 98% and looking good.The general approach is fairly similar to AFN with a simplification of not having to swizzle the
NSURLSessionTask.Statechanges since we can rely on theRequestmethods directly. While this approach does not work if the user uses the task property directly toresumeorsuspendthe task, this should be able to be resolved with documentation. This is certainly a better tradeoff than swizzling the task state. AFN couldn't use this approach b/c there is no concept of aRequest.@jshier and I have a huge conversation on the design choices of using
NSNotificationinstead of closures on theManagerorRequestclasses. We decided that it is best in this case to use notifications since it is a broadcast that could have multiple observers.