Add conformance tests for shifting out of range #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
force-pushed
the
shift
branch
2 times, most recently
from
9b27cec
to
fe927ae
Compare
The Linux verifier rejects shifting by imm out of range so did not add tests for those cases. Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler
changed the title
Alan-Jowett
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux verifier rejects shifting by imm out of range so did not add tests for those cases.
If there is a way to allow verifier rejection as "pass" we could add them for runtimes that do accept them.
Fixes #100