Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lock_xchg* test to return 1 on failure #258

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix lock_xchg* test to return 1 on failure #258

merged 2 commits into from
May 28, 2024

Conversation

Alan-Jowett
Copy link
Owner

Set %r0 at the start of the test. Only set %r0 to zero if all the checks pass.

Resolves: #227

Fix lock_xchg* test to return 1 on failure
bae77c7 
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
@coveralls
Copy link

coveralls commented May 28, 2024 •
edited

Coverage Status

coverage: 95.147% (-0.2%) from 95.339%
when pulling 34ad05b on issue227
into 032f730 on main.

@Alan-Jowett Alan-Jowett merged commit 3e13718 into main May 28, 2024
17 of 19 checks passed
@Alan-Jowett Alan-Jowett deleted the issue227 branch May 28, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv-msft dv-msft dv-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests seems to imply that xchg and xchg32 stores the old value in r0
3 participants
@Alan-Jowett @coveralls @dv-msft