Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PUBLIC value from TRUE to FALSE #122

Closed
blackfalcon opened this issue Aug 2, 2023 · 2 comments · Fixed by #123
Closed

Change PUBLIC value from TRUE to FALSE #122

blackfalcon opened this issue Aug 2, 2023 · 2 comments · Fixed by #123
Assignees
@jordanjones243
Labels
design tokens Type: Feature New Feature
Milestone
Prepare for theme...

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, with all the Auro Design Tokens there is a public attribute. See the code example below.

AuroDesignTokens/src/color/alert.json

Lines 5 to 14 in c4017db

"onLight": {
"value": "{color.brand.atlas.400.value}",
"public": true,
"onLight": true,
"usage": "Notification color on light backgrounds",
"wcag": "AAA",
"deprecated": true,
"comment": "Deprecated token",
"reference": "color-alert-notification-default",
"version": "3.15.0"

This setting will allow the token to be output in the various formats described in the config.json file.

Describe the solution you'd like

Specifically for the deprecated tokens, for the 4.0 release, we will change public: true to public: false.

This will allow the token to be retained in the repo, and be listed in the deprecated tokens file./dist/JSObject--deprecated.js but not allow the tokens to be exported to the other resources.

Describe alternatives you've considered

Deleting the tokens outright, but will also negate the deprecated tokens list and make it hard for any consumer to know what token to change to.

Additional context

This issue will be considered complete once all the deprecated tokens' public status has been updated.
@blackfalcon blackfalcon added this to the Prepare for themed tokens milestone Aug 2, 2023
@jordanjones243 jordanjones243 mentioned this issue Aug 7, 2023
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 7, 2023 that will close this issue
Prepare for themed tokens - milestone #123
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Aug 7, 2023
@jordanjones243
perf(public): change public value in deprecated tokens from true to f…
5f9ab6b 
…alse #122
blackfalcon pushed a commit that referenced this issue Sep 7, 2023
@jordanjones243 @blackfalcon
perf(public): change public value in deprecated tokens from true to f…
ef01d5e 
…alse #122
blackfalcon pushed a commit that referenced this issue Sep 7, 2023
@jordanjones243 @blackfalcon
perf(public): change value of deprecated tokens #122
c0d7107 
BREAKING CHANGE: This commit changes the public access
of the token from `true` to `false`. This setting will restrict
the distribution of the token into the various distributed
generated resources.

Changes to be committed:
modified:   src/breakpoint.json
modified:   src/color-dark/base.json
modified:   src/color/alert.json
modified:   src/color/base.json
modified:   src/color/border.json
modified:   src/color/icon.json
modified:   src/color/text.json
modified:   src/color/tier.json
modified:   src/color/ui.json
modified:   src/depth.json
modified:   src/shadow.json
modified:   src/size/scale.json
@blackfalcon
Copy link
Member Author

Using this BREAKING CHANGE, we should also update the package namespace to @aurodesignsystem.

blackfalcon added a commit that referenced this issue Sep 7, 2023
@blackfalcon
chore: update npm namespace #122
f20ff04 
BREAKING CHANGE: This commit updates the npm namespace
from @alaskaairux to @AuroDesignSystem

Changes to be committed:
modified:   package.json
@blackfalcon
Copy link
Member Author

Tokens for this repo have been updated to support the new namespace.

blackfalcon pushed a commit that referenced this issue Sep 7, 2023
@jordanjones243 @blackfalcon
perf(public): change value of deprecated tokens #122
d2f3309 
BREAKING CHANGE: This commit changes the public access
of the token from `true` to `false`. This setting will restrict
the distribution of the token into the various distributed
generated resources.

Changes to be committed:
modified:   src/breakpoint.json
modified:   src/color-dark/base.json
modified:   src/color/alert.json
modified:   src/color/base.json
modified:   src/color/border.json
modified:   src/color/icon.json
modified:   src/color/text.json
modified:   src/color/tier.json
modified:   src/color/ui.json
modified:   src/depth.json
modified:   src/shadow.json
modified:   src/size/scale.json
blackfalcon added a commit that referenced this issue Sep 7, 2023
@blackfalcon
chore: update npm namespace #122
4ffd435 
BREAKING CHANGE: This commit updates the npm namespace
from @alaskaairux to @AuroDesignSystem

Changes to be committed:
modified:   package.json
jordanjones243 added a commit that referenced this issue Sep 13, 2023
@jordanjones243
perf(public): change value of deprecated tokens #122
427f8d9 
BREAKING CHANGE: This commit changes the public access
of the token from `true` to `false`. This setting will restrict
the distribution of the token into the various distributed
generated resources.

Changes to be committed:
modified:   src/breakpoint.json
modified:   src/color-dark/base.json
modified:   src/color/alert.json
modified:   src/color/base.json
modified:   src/color/border.json
modified:   src/color/icon.json
modified:   src/color/text.json
modified:   src/color/tier.json
modified:   src/color/ui.json
modified:   src/depth.json
modified:   src/shadow.json
modified:   src/size/scale.json
jordanjones243 pushed a commit that referenced this issue Sep 13, 2023
@blackfalcon @jordanjones243
chore: update npm namespace #122
1ef7d41 
BREAKING CHANGE: This commit updates the npm namespace
from @alaskaairux to @AuroDesignSystem

Changes to be committed:
modified:   package.json
blackfalcon pushed a commit that referenced this issue Sep 13, 2023
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
1465d35 
# [4.0.0](v3.15.5...v4.0.0) (2023-09-13)

### Bug Fixes

* **comment:** update comment of dark mode token ([a735309](a735309))
* **token:** fix typo in dark token config ([461f5eb](461f5eb))

### chore

* update npm namespace [#122](#122) ([1ef7d41](1ef7d41))

### Features

* **prefix:** BREAKING CHANGE update token prefix from auro to ds [#118](#118) ([9aaa33a](9aaa33a))

### Performance Improvements

* **darkmode:** update token naming convention [#129](#129) ([83fee5a](83fee5a))
* **public:** change value of deprecated tokens [#122](#122) ([427f8d9](427f8d9))

### BREAKING CHANGES

* This commit updates the npm namespace
from @alaskaairux to @AuroDesignSystem

Changes to be committed:
modified:   package.json
* **public:** This commit changes the public access
of the token from `true` to `false`. This setting will restrict
the distribution of the token into the various distributed
generated resources.

Changes to be committed:
modified:   src/breakpoint.json
modified:   src/color-dark/base.json
modified:   src/color/alert.json
modified:   src/color/base.json
modified:   src/color/border.json
modified:   src/color/icon.json
modified:   src/color/text.json
modified:   src/color/tier.json
modified:   src/color/ui.json
modified:   src/depth.json
modified:   src/shadow.json
modified:   src/size/scale.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
design tokens Type: Feature New Feature
Projects
None yet
Milestone
Prepare for themed tokens (v4.0 release)
Development

Successfully merging a pull request may close this issue.

Prepare for themed tokens - milestone AlaskaAirlines/AuroDesignTokens
2 participants
@blackfalcon @jordanjones243