Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new size token #124

Closed
leeejune opened this issue Aug 8, 2023 · 0 comments · Fixed by #148
Closed

Add new size token #124

leeejune opened this issue Aug 8, 2023 · 0 comments · Fixed by #148
Assignees
@leeejune
Labels
design tokens not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@leeejune
Copy link
Contributor

leeejune commented Aug 8, 2023

Is your feature request related to a problem? Please describe.

0.375 (6px) is often used as padding and border radius. We do not have a design token for it in the general "size" category of tokens.

Describe the solution you'd like

Add auro-size-75: 0.375rem to use as border radius as well as a padding value. The suggestion is that the current border radius value to be changed to reference this new design token as a base token.
@leeejune leeejune added Type: Feature New Feature design tokens not-reviewed Issue has not been reviewed by Auro team members labels Aug 8, 2023
@leeejune leeejune self-assigned this Aug 8, 2023
@blackfalcon blackfalcon linked a pull request May 7, 2024 that will close this issue
Add support for iOS #148
Merged
6 tasks
@blackfalcon blackfalcon mentioned this issue May 7, 2024
Merged
6 tasks
blackfalcon added a commit that referenced this issue May 7, 2024
@blackfalcon
perf: convert hard value to token #124
80445f7 
This commit takes the currently used 0.375 and converts it to a base
token of ds-size-75.

Changes to be committed:
modified:   src/size/radius.json
modified:   src/size/scale.json
blackfalcon added a commit that referenced this issue May 7, 2024
@blackfalcon
perf: convert hard value to token #124
79e5f56 
This commit takes the currently used 0.375 and converts it to a base
token of ds-size-75.

Changes to be committed:
modified:   src/size/radius.json
modified:   src/size/scale.json
jason-capsule42 pushed a commit that referenced this issue May 9, 2024
@blackfalcon @jason-capsule42
perf: convert hard value to token #124
f54d4f4 
This commit takes the currently used 0.375 and converts it to a base
token of ds-size-75.

Changes to be committed:
modified:   src/size/radius.json
modified:   src/size/scale.json
blackfalcon pushed a commit that referenced this issue May 9, 2024
@semantic-release-bot
chore(release): 4.4.0 [skip ci]
5e5dce9 
# [4.4.0](v4.3.1...v4.4.0) (2024-05-09)

### Features

* add support for JSON flat and nested [#144](#144) ([af7a657](af7a657))

### Performance Improvements

* convert hard value to token [#124](#124) ([f54d4f4](f54d4f4))
jason-capsule42 pushed a commit that referenced this issue May 16, 2024
@blackfalcon @jason-capsule42
perf: convert hard value to token #124
470b57a 
This commit takes the currently used 0.375 and converts it to a base
token of ds-size-75.

Changes to be committed:
modified:   src/size/radius.json
modified:   src/size/scale.json
jason-capsule42 pushed a commit that referenced this issue May 16, 2024
@semantic-release-bot @jason-capsule42
chore(release): 4.4.0 [skip ci]
e9b2ba5 
# [4.4.0](v4.3.1...v4.4.0) (2024-05-09)

### Features

* add support for JSON flat and nested [#144](#144) ([af7a657](af7a657))

### Performance Improvements

* convert hard value to token [#124](#124) ([f54d4f4](f54d4f4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leeejune leeejune

Labels
design tokens not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for iOS AlaskaAirlines/AuroDesignTokens
1 participant
@leeejune