Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro design tokens: add color tokens for different states #60

Closed
leeejune opened this issue Dec 2, 2021 · 4 comments · Fixed by #62
Closed

auro design tokens: add color tokens for different states #60

leeejune opened this issue Dec 2, 2021 · 4 comments · Fixed by #62
Assignees
@blackfalcon @leeejune
Labels
design tokens Status: Work In Progress Issue or Pull Request work is in Progress

Comments

@leeejune
Copy link
Contributor

leeejune commented Dec 2, 2021

Is your feature request related to a problem? Please describe.

There are no color tokens for backgrounds in a hover/active state.

Describe the solution you'd like

Add color tokens to the design system.

Additional context

We will need to add another name category for these new tokens. Ex: auro-color-ui-background-hover-on-dark
@leeejune
Copy link
Contributor Author

leeejune commented Dec 2, 2021

@blackfalcon Are there any naming conventions that I should be aware of?

@blackfalcon
Copy link
Member

@leeejune yes. Please review the names of all the existing tokens and there should be a logical placement of a new token.

The naming is created based on the data structure of the token in the JSON.

If you need help, please let me know.

@leeejune
Copy link
Contributor Author

leeejune commented Dec 8, 2021

Requesting these color tokens to be added to the color palette: https://www.figma.com/file/TBMhIMVRMkufKnyxqGzrZO/Color-Explorations?node-id=8%3A1150

@blackfalcon
Copy link
Member

Also noticed that the settings.yml is really out of date. Will take this opportunity to get this up to speed.

@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro Dec 11, 2021
This was referenced Dec 11, 2021
Closed
Merged
blackfalcon added a commit that referenced this issue Dec 11, 2021
@blackfalcon
feat(color ui): add new ui background tokens #60
c1d54c1 
Changes to be committed:
modified:   src/color/ui.json
@blackfalcon blackfalcon linked a pull request Dec 11, 2021 that will close this issue
Add new ui background tokens #62
Merged
6 tasks
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress design tokens labels Dec 11, 2021
blackfalcon added a commit that referenced this issue Dec 14, 2021
@blackfalcon
feat(color ui): add new ui background tokens #60
85b7bba 
Changes to be committed:
modified:   src/color/ui.json
AuroDesignSystem pushed a commit that referenced this issue Dec 14, 2021
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
bcbd593 
# [3.5.0](v3.4.0...v3.5.0) (2021-12-14)

### Features

* **color ui:** add new ui background tokens [#60](#60) ([85b7bba](85b7bba))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@leeejune leeejune

Labels
design tokens Status: Work In Progress Issue or Pull Request work is in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new ui background tokens AlaskaAirlines/AuroDesignTokens
2 participants
@blackfalcon @leeejune