Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accent text color token #83

Closed
leeejune opened this issue Sep 8, 2022 · 0 comments · Fixed by #87
Closed

Add accent text color token #83

leeejune opened this issue Sep 8, 2022 · 0 comments · Fixed by #87
Assignees
@leeejune
Labels
design tokens Type: Feature New Feature

Comments

@leeejune
Copy link
Contributor

leeejune commented Sep 8, 2022

Is your feature request related to a problem? Please describe.
Designers have been using auro-color-background-darker for accent text color.

Describe the solution you'd like
Add an accent text color token (midnight-400).
auro-color-text-accent-on-light: var(--auro-color-brand-midnight-400)

Describe alternatives you've considered
Using the personality palette for text has been considered, but there were concerns around maintaining consistency across accent text.
@leeejune leeejune added the Type: Feature New Feature label Sep 8, 2022
leeejune added a commit that referenced this issue Sep 28, 2022
@leeejune
feat: add emphasis text color #83
1b35b1b
@leeejune leeejune mentioned this issue Sep 28, 2022
Merged
6 tasks
@leeejune leeejune linked a pull request Oct 4, 2022 that will close this issue
feat: add emphasis text color #83 #87
Merged
6 tasks
@leeejune leeejune self-assigned this Oct 6, 2022
blackfalcon pushed a commit that referenced this issue Oct 6, 2022
@leeejune @blackfalcon
feat(emphasis): add new semantic text color #83
3774ab1 
Changes to be committed:
modified:   src/color/text.json
blackfalcon pushed a commit that referenced this issue Oct 6, 2022
@leeejune @blackfalcon
feat(emphasis): add new semantic text color #83
d44a1ea 
Changes to be committed:
modified:   src/color/text.json
AuroDesignSystem pushed a commit that referenced this issue Oct 6, 2022
@semantic-release-bot
chore(release): 3.11.0 [skip ci]
9a79510 
# [3.11.0](v3.10.0...v3.11.0) (2022-10-06)

### Features

* **emphasis:** add new semantic text color [#83](#83) ([d44a1ea](d44a1ea))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leeejune leeejune

Labels
design tokens Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add emphasis text color #83 AlaskaAirlines/AuroDesignTokens
2 participants
@blackfalcon @leeejune