Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode design tokens #88

Closed
blackfalcon opened this issue Nov 17, 2022 · 0 comments · Fixed by #89
Closed

Dark mode design tokens #88

blackfalcon opened this issue Nov 17, 2022 · 0 comments · Fixed by #89
Assignees
@jordanjones243
Labels
design tokens Type: Feature New Feature
Milestone
v3.15-rc Theme an...

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Nov 17, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

As part of the theming work, support for generating dark mode design tokens is needed.

Describe the solution you'd like

From the design token repo we need to export a series of values to be used in dark mode. A preferred method of use is to conditional load them in the global scope of the app.

<link rel="stylesheet" href="/dark-tokens.css" media="(prefers-color-scheme: dark)" />

For token management, we need to understand this post more https://dbanks.design/blog/dark-mode-with-style-dictionary/

Specifically this part on the Multi-file method.

Exit criteria

For this issue to be closed a user must be able to subscribe to a series of darkmode design tokens for use within their project.

Dependency
@blackfalcon blackfalcon added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members labels Nov 17, 2022
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-button Nov 17, 2022
@blackfalcon blackfalcon mentioned this issue Feb 17, 2023
Closed
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Nov 17, 2022
@jordanjones243 jordanjones243 self-assigned this Nov 22, 2022
This was referenced Nov 23, 2022
Closed
Closed
jordanjones243 added a commit that referenced this issue Nov 23, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
ff3f97c
jordanjones243 added a commit that referenced this issue Nov 28, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
ecf2eda
jordanjones243 added a commit that referenced this issue Nov 28, 2022
@jordanjones243
feat(dark): add dark theme variables build configuration #88
6d283e5
jordanjones243 added a commit that referenced this issue Nov 28, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
ec925f3
jordanjones243 added a commit that referenced this issue Nov 28, 2022
@jordanjones243
feat(dark): add dark theme variables build configuration #88
2165405
@jordanjones243 jordanjones243 mentioned this issue Nov 28, 2022
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Nov 28, 2022 that will close this issue
Create dark mode design token set #89
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Nov 28, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
bdafeb0
jordanjones243 added a commit that referenced this issue Nov 28, 2022
@jordanjones243
feat(dark): add dark theme token build configuration #88
9dd5d9c
jordanjones243 added a commit that referenced this issue Nov 29, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
7438cbe
jordanjones243 added a commit that referenced this issue Nov 29, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
f1c2cd4
jordanjones243 added a commit that referenced this issue Nov 29, 2022
@jordanjones243
feat(theme): add build configuration for dark theme tokens #88
9faa0c0
jordanjones243 added a commit that referenced this issue Nov 30, 2022
@jordanjones243
feat(theme): add build configuration for dark theme tokens #88
edc2eb7
jordanjones243 added a commit that referenced this issue Dec 1, 2022
@jordanjones243
feat(theme): add build configuration for dark theme tokens #88
b45f93b
jordanjones243 added a commit that referenced this issue Dec 8, 2022
@jordanjones243
refactor(theme): separate color tokens for light and dark themes #88
8e1c3c6
jordanjones243 added a commit that referenced this issue Dec 8, 2022
@jordanjones243
feat(theme): add build configuration for dark theme tokens #88
a58b02b
jason-capsule42 pushed a commit that referenced this issue Dec 13, 2022
@jordanjones243 @jason-capsule42
refactor(theme): separate color tokens for light and dark themes #88
f349c22
jason-capsule42 pushed a commit that referenced this issue Dec 13, 2022
@jordanjones243 @jason-capsule42
feat(theme): add build configuration for dark theme tokens #88
87d8d75
AuroDesignSystem pushed a commit that referenced this issue Dec 13, 2022
@semantic-release-bot
chore(release): 3.12.0 [skip ci]
0af83f8 
# [3.12.0](v3.11.0...v3.12.0) (2022-12-13)

### Features

* **theme:** add build configuration for dark theme tokens [#88](#88) ([87d8d75](87d8d75))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
design tokens Type: Feature New Feature
Projects
None yet
Milestone
v3.15-rc Theme and darkmode support
Development

Successfully merging a pull request may close this issue.

Create dark mode design token set AlaskaAirlines/AuroDesignTokens
3 participants
@blackfalcon @braven112 @jordanjones243