Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The color tokens do not have a reference object within it's data #96

Closed
jordanjones243 opened this issue Feb 3, 2023 · 0 comments · Fixed by #97
Closed

The color tokens do not have a reference object within it's data #96

jordanjones243 opened this issue Feb 3, 2023 · 0 comments · Fixed by #97
Assignees
@jordanjones243
Labels
design tokens Type: Bug Bug or Bug fixes

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Feb 3, 2023 •
edited
Loading

Describe the bug

None of the color tokens have a reference object within their JSON data, causing an error when trying to build out the list of deprecated tokens.

To Reproduce

Steps to reproduce the behavior:

  1. Use a local version of the docsite
  2. Update with this command npm i @alaskaairux/design-tokens@3.12.1
  3. Run the server locally
  4. Go to http://localhost:3000/getting-started/developers/design-tokens/deprecated
  5. See the error

Expected behavior

The deprecated tokens list should be generated on the docsite.

Screenshot

This is an example of what the deprecated token data should look like (not the reference and version data).

Screen Shot 2023-02-06 at 9 47 00 AM

Screen Shot 2023-02-06 at 9 48 52 AM

Additional context

This bug was discovered through investigative work stemming from this issue:

The color tokens are also missing a version object, but the absence of this object does not produce an error.
@jordanjones243 jordanjones243 added Type: Bug Bug or Bug fixes design tokens not-reviewed Issue has not been reviewed by Auro team members labels Feb 3, 2023
@jordanjones243 jordanjones243 self-assigned this Feb 3, 2023
@jordanjones243 jordanjones243 mentioned this issue Feb 3, 2023
Closed
@jordanjones243 jordanjones243 changed the title The color tokens do not have a reference object The color tokens do not have a reference object within it's data Feb 6, 2023
jordanjones243 added a commit that referenced this issue Feb 6, 2023
@jordanjones243
fix(json): add reference and version data to tokens #96
74d4cbb
@jordanjones243 jordanjones243 mentioned this issue Feb 6, 2023
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Feb 6, 2023 that will close this issue
fix(json): add reference and version data to tokens #96 #97
Merged
6 tasks
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Feb 6, 2023
blackfalcon pushed a commit that referenced this issue Feb 6, 2023
@jordanjones243 @blackfalcon
fix(json): add reference and version data to tokens #96
52081b3
AuroDesignSystem pushed a commit that referenced this issue Feb 6, 2023
@semantic-release-bot
chore(release): 3.12.2 [skip ci]
b60fc6f 
## [3.12.2](v3.12.1...v3.12.2) (2023-02-06)

### Bug Fixes

* **json:** add reference and version data to tokens [#96](#96) ([52081b3](52081b3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
design tokens Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(json): add reference and version data to tokens #96 AlaskaAirlines/AuroDesignTokens
2 participants
@blackfalcon @jordanjones243