Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new body height token #85

Closed
wants to merge 1 commit into from
Closed

Conversation

jordanjones243
Copy link
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #84

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Add token that represents the height of all form elements before additional css (padding, margin & border) is applied.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 requested review from leeejune and a team September 22, 2022 21:03
@jordanjones243 jordanjones243 self-assigned this Sep 22, 2022
@jordanjones243 jordanjones243 linked an issue Sep 22, 2022 that may be closed by this pull request
@jordanjones243
Copy link
Contributor Author

AC:
This variable and value represent the height for the a peer dependency element. For example, for auro-select, we would assign the height of the dropdown within select to have a min/max height equal to this variable. Let me know if the naming is confusing or how I can make it more clear for users.

@blackfalcon
Copy link
Member

I am wondering if we should take a different approach to this. Really, this isn't a font-size thing, so I don't feel comfortable creating this new token where it is proposed.

But looking at this, there is this issue that hasn't been addressed yet. #71 (comment)

If we add var(--auro-size-500) which would be 2.5rem and then the height we would use for the form elements is consistent with other sizing tokens.

This would also better refactor this update as well. https://github.com/AlaskaAirlines/auro-select/pull/98/files

@leeejune you want me to make this update?

@leeejune
Copy link
Contributor

@blackfalcon I'm not sure what update that needs to be made, so that might be better. But I will make updates to add var(--auro-size-500) in Figma and design documentation.

@blackfalcon blackfalcon deleted the jordanjones243/formHeight/#84 branch October 6, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add min/max form element height token
3 participants