Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SSR #52

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Update to SSR #52

merged 3 commits into from
Jan 20, 2024

Conversation

blackfalcon
Copy link
Member

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #51

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Changes to be committed:
renamed:    commitlint.config.js -> commitlint.config.cjs
modified:   package-lock.json
modified:   package.json
modified:   packageScripts/postinstall.mjs
deleted:    scripts/postCss.js
new file:   scripts/postCss.mjs
modified:   scripts/pre-commit.mjs
Changes to be committed:
modified:   package-lock.json
modified:   package.json
@blackfalcon blackfalcon linked an issue Jan 11, 2024 that may be closed by this pull request
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once script path is updated, this PR is approved. SSR has been tested via Svelte.

package.json Outdated
@@ -139,7 +141,7 @@
"esLint": "./node_modules/.bin/eslint src/auro-*.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "esLint" script should be: "esLint": "eslint src/auro-*.js",

Changes to be committed:
modified:   package-lock.json
modified:   package.json
@blackfalcon blackfalcon merged commit 0c56bcf into main Jan 20, 2024
4 checks passed
@blackfalcon blackfalcon deleted the dsande/ssr/51 branch January 20, 2024 01:57
@blackfalcon
Copy link
Member Author

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SSR Support
2 participants