-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auro-badge: status and club badges #41
Comments
The easiest option I see here is extending the already in-use attributes (error, success, and advisory) to encompass these additional colors. The colors requested are part of the Auro Design Tokens, so there is no additional design work required. What is the feedback from @leeejune and @jason-capsule42 ? |
It's a pretty easy add to Figma too, so I can add it if we add the attributes. |
@blackfalcon & @leeejune where would this sort of thing fall on the auro priority list? Do you have a rough timeline on when you might make it to this? |
@Dayna-A I have made a request to have this update prioritized. |
I just tried to get started on this but I believe we are dependent on this issue being finished first. #29 We have a bunch of other work higher priority list but seems like a super simple update, outside of #29 needing to be finished first. Great candidate for open source contribution from anyone assuming we are going with @blackfalcon's approach above. |
Ok. would the 'alaska state' icon need adding to auro-icons first? Our team isn't quite ready to pull this in if it is via innersourcing so maybe keep us posted? |
We can add this as a feature enhancement to the overall Node 18 milestone. That I am not concerned with. |
…Airlines/auro-badge into bshields/#41/custombadges
I have a draft PR for this change started. We have a few design tokens we need added as well as the Alaska State icon before we can merge. |
Hello everyone. Here are the types of badges from JetStream that are being used in RAIN. Elite status MVP — #00436D Fare Classes Saver — #E27A05 Oneworld Elite Ruby — #9C305A The ones in italic are similar to what already exists but with a slightly different label. Not sure what the best way to resolve that is. |
Thanks Andri! I'll include "auro" version of these badges and when we are ready for themeing on this repo we can introduce the "jetstream" themed versions. |
@braven112 @blackfalcon do you have any status updates on this? |
@Patrick-Daly-AA alerting you do this issue. |
We haven't made any additional progress this sprint. Are the lounge badges the ones you are specifically waiting for? |
@braven112 we are waiting on the Lounge, Tier and the Club 49 badges |
@Dayna-A I am taking this over as this has been sitting way too long. Sorry. I have a question though. There is a new color being requested that is not part of the current baseline brand colors. It's the We have an existing color for |
I'm so sorry i don't get these notifications nicely for these repos. @blackfalcon That seems like a question for our loyalty branding group. Can we just add the existing branded colour for Lounge Plus? |
@blackfalcon I connected with our designers and they said it is fine to go with the existing colour. Sorry again for the delayed response. I have updated my GH notifications |
@braven112, @blackfalcon , @leeejune I'm sorry for missing the notification on this one back in September. Is there anything else we can do to support this? Would support for the 1 and two million miler badges be considered in here? |
@Dayna-A trying to get this back on track. Sorry for the very long wait on this. |
That's ok. Sorry to miss replying in a timely manner |
@blackfalcon bump |
Closing this issue since we are breaking up this ask into multiple parts. #98 is a larger fix since it includes icons that aren't part of the repo for performance reason at the moment. |
Is your feature request related to a problem? Please describe.
The same customizations for our alaska tier badges, oneworld tier badges, Club 49 badge(new) , Lounge & Lounge+ badges(also new) are being done in many places across AsCom. The desire to keep those aligned between micro-sites is clear (designers are collaborating together to have their teams keep updating them to align).
Describe the solution you'd like
These custom badges to exist as 'themes' in the existing auro badge component so that we can all easily use the same badges for guest statuses and easily keep them aligned across our guest experiences.
Describe alternatives you've considered
Club 49:
Figma for our current work:
https://www.figma.com/file/InsfVhuoqSJi85TXXfWykN/Lounge-In---Scan-entry?node-id=2654%3A8709&t=yakjPvJHZzgiXzgq-1
One place these customizations are already implemented by another team: [Awards balance box Hangar Component]
](https://components.alaskaair.com/catelog/demo/awards-balance-box)
The text was updated successfully, but these errors were encountered: