Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon rendering issue #246

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Fix icon rendering issue #246

merged 7 commits into from
Feb 14, 2024

Conversation

jordanjones243
Copy link
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #245

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update code to get icons to render in iconOnly examples
  • Update demo example code and documentation
  • Fix styles of iconOnly buttons

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Feb 13, 2024
@jordanjones243 jordanjones243 linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 13, 2024

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

@jordanjones243 jordanjones243 marked this pull request as ready for review February 13, 2024 22:13
@jordanjones243 jordanjones243 requested a review from a team as a code owner February 13, 2024 22:13
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed example

Screen Shot 2024-02-14 at 10 50 38 AM

@jordanjones243 jordanjones243 marked this pull request as draft February 14, 2024 18:58
Changes to be committed:
modified:   package-lock.json
modified:   package.json
@blackfalcon blackfalcon marked this pull request as ready for review February 14, 2024 19:19
@blackfalcon blackfalcon merged commit 83b4486 into master Feb 14, 2024
7 checks passed
@blackfalcon blackfalcon deleted the jjones/iconOnlyRendering/#245 branch February 14, 2024 19:22
@blackfalcon
Copy link
Member

🎉 This PR is included in version 7.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are not rendering for iconOnly buttons
2 participants