Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border between calendars off-center #242

Closed
arrenleung opened this issue Jul 2, 2024 · 0 comments · Fixed by #243
Closed

Border between calendars off-center #242

arrenleung opened this issue Jul 2, 2024 · 0 comments · Fixed by #243
Labels
auro-datepicker Type: Bug Bug or Bug fixes

Comments

@arrenleung
Copy link
Contributor

Please verify the version of auro-datepicker you have installed

2.6.0

Please describe the bug

  1. Go to a ranged datepicker and open the calendars
  2. See that the border separating the two months is off-center to the left

image

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

The border between two datepicker calendars is centered

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

The ::after styles that apply to the left calendar seem to be applying to the calendar's padding, when it should be applying to the calendars padding AND margin:

image
image

Exit criteria

No response
@arrenleung arrenleung added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jul 2, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jul 3, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Jul 3, 2024
jason-capsule42 added a commit that referenced this issue Jul 4, 2024
@jason-capsule42
fix(calendar): make divider center correctly with range support #242
d46f8af
@jason-capsule42 jason-capsule42 mentioned this issue Jul 4, 2024
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jul 4, 2024 that will close this issue
Jbaker/UI fixes #243
Merged
6 tasks
jason-capsule42 added a commit that referenced this issue Jul 9, 2024
@jason-capsule42
fix(calendar): make divider center correctly with range support #242
542c0fc
blackfalcon pushed a commit that referenced this issue Jul 9, 2024
@semantic-release-bot
chore(release): 2.6.1 [skip ci]
d321ee9 
## [2.6.1](v2.6.0...v2.6.1) (2024-07-09)

### Bug Fixes

* **calendar:** make divider center correctly with range support [#242](#242) ([542c0fc](542c0fc))
* **day:** selected date price is now the right color [#239](#239) ([fa9968e](fa9968e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-datepicker Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jbaker/UI fixes AlaskaAirlines/auro-datepicker
2 participants
@arrenleung @Patrick-Daly-AA