Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minified js system #199

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

jordanjones243
Copy link
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #198

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Implement current minified js system that runs the js for examples on the demo files.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Feb 9, 2024
@jordanjones243
Copy link
Contributor Author

This PR is currently sitting in draft mode because the focus example is not working as intended.

@jordanjones243 jordanjones243 linked an issue Feb 12, 2024 that may be closed by this pull request
@jordanjones243 jordanjones243 marked this pull request as ready for review February 13, 2024 21:26
@jordanjones243 jordanjones243 requested a review from a team as a code owner February 13, 2024 21:26
@jordanjones243
Copy link
Contributor Author

Take note: the programmatic focus example was removed from the repo. Adding focus programmatically does not give the same UX as when a user applys focus to a hyperlink via tabbing.

@jordanjones243
Copy link
Contributor Author

Take note: the programmatic focus example was removed from the repo. Adding focus programmatically does not give the same UX as when a user applys focus to a hyperlink via tabbing.

I can confirm that this example does not work on the localhost in main, nor on the docsite

package.json Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 620bbe8 into main Feb 19, 2024
6 checks passed
@jason-capsule42 jason-capsule42 deleted the jordanjones243/demoJs/#198 branch February 19, 2024 22:37
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.5.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement minified js system for demos
3 participants