Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing discrepancies #152

Closed
leeejune opened this issue Aug 25, 2022 · 0 comments · Fixed by #177
Closed

Spacing discrepancies #152

leeejune opened this issue Aug 25, 2022 · 0 comments · Fixed by #177
Assignees
@jason-capsule42
Labels
auro-menu not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes Type: Design New or related Design work
Milestone
auro-menu v3.10-rc

Comments

@leeejune
Copy link
Contributor

leeejune commented Aug 25, 2022 •
edited

Describe the bug

The spacing for menu items is not accurate to the blueprint. Also, there has been some updates in the blueprint since the no checkmark selection (issue #136).

Also, due to these discrepancies, there is a visual "jump" between menu items.

To Reproduce

Steps to reproduce the behavior:

  1. Click on a menu item
  2. Click on the menu item right below it
  3. See that the menu item text is not lined up.

For more spacing differences, see menu item and compare to blueprint.

Expected behavior

https://www.figma.com/file/xwDiIDfSz6j9bM4TD3Ni5N/Menu?node-id=1019%3A3657
Added spacing specs for each menu item for better readability. Check link for correct specs in the blueprint.

Screenshots

Screen Shot 2022-08-24 at 4 51 31 PM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
@leeejune leeejune added Type: Bug Bug or Bug fixes Type: Design New or related Design work auro-menu not-reviewed Issue has not been reviewed by Auro team members labels Aug 25, 2022
@blackfalcon blackfalcon added this to the v3.10-rc auro-menu milestone Feb 23, 2023
@jason-capsule42 jason-capsule42 self-assigned this May 23, 2023
jason-capsule42 added a commit that referenced this issue May 23, 2023
@jason-capsule42
fix(layout): correct margin on selected icon #152
28b3105
@jason-capsule42 jason-capsule42 linked a pull request May 23, 2023 that will close this issue
Jbaker/example updates #177
Merged
6 tasks
@jordanjones243 jordanjones243 mentioned this issue May 23, 2023
Merged
6 tasks
jason-capsule42 added a commit that referenced this issue May 23, 2023
@jason-capsule42
fix(layout): correct margin on selected icon #152
d5c2360
blackfalcon pushed a commit that referenced this issue May 23, 2023
@semantic-release-bot
chore(release): 3.10.0 [skip ci]
170f3af 
# [3.10.0](v3.9.5...v3.10.0) (2023-05-23)

### Bug Fixes

* **layout:** correct margin on selected icon [#152](#152) ([d5c2360](d5c2360))

### Features

* **disable:** enable disabling entire menu rather than just options individually [#175](#175) ([db507fd](db507fd))

### Performance Improvements

* **deps:** update several dependencies to latest versions ([685ee09](685ee09))
* **examples:** refactor js example execution so it works on docsite [#176](#176) ([ffe429f](ffe429f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
auro-menu not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes Type: Design New or related Design work
Projects
None yet
Milestone
auro-menu v3.10-rc
Development

Successfully merging a pull request may close this issue.

Jbaker/example updates AlaskaAirlines/auro-menu
3 participants
@blackfalcon @jason-capsule42 @leeejune