Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-menu: Theming support #184

Closed
braven112 opened this issue Oct 5, 2023 · 0 comments · Fixed by #185
Closed

auro-menu: Theming support #184

braven112 opened this issue Oct 5, 2023 · 0 comments · Fixed by #185
Labels
auro-menu Type: Feature New Feature

Comments

@braven112
Copy link
Member

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231

Exit criteria

All tokens referencing --auro have been updated.
Validate the changes after this work item is also complete
@braven112 braven112 added Type: Feature New Feature auro-menu not-reviewed Issue has not been reviewed by Auro team members labels Oct 5, 2023
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Oct 5, 2023
fajar-apri-alaska added a commit that referenced this issue Oct 9, 2023
@fajar-apri-alaska
perf(token): update token per new theming #184
8c6c9e7 
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-base.scss
	modified:   src/style-menuoption.scss
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Oct 9, 2023
Merged
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request Oct 9, 2023 that will close this issue
Update CSS token per new design system theming capability #185
Merged
3 tasks
fajar-apri-alaska added a commit that referenced this issue Oct 9, 2023
@fajar-apri-alaska
perf(token): update token per new theming #184
8289c14 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-base.scss
	modified:   src/style-menuoption.scss
fajar-apri-alaska added a commit that referenced this issue Oct 11, 2023
@fajar-apri-alaska
perf(token): update token per new theming #184
cbdabb5 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-base.scss
	modified:   src/style-menuoption.scss
jason-capsule42 pushed a commit that referenced this issue Oct 30, 2023
@fajar-apri-alaska @jason-capsule42
perf(token): update token per new theming #184
1040c24 
Changes to be committed:
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-base.scss
	modified:   src/style-menuoption.scss
blackfalcon pushed a commit that referenced this issue Oct 30, 2023
@semantic-release-bot
chore(release): 3.10.2 [skip ci]
6dbc6f2 
## [3.10.2](v3.10.1...v3.10.2) (2023-10-30)

### Performance Improvements

* **token:** update token per new theming [#184](#184) ([1040c24](1040c24))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-menu Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CSS token per new design system theming capability AlaskaAirlines/auro-menu
3 participants
@blackfalcon @braven112 @Patrick-Daly-AA