Enhance selected option example #195
Draft
+207
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jason-capsule42
requested changes
Feb 29, 2024
| @@ -144,9 +144,9 @@ The `auro-menuoption` element supports the placement of the `disabled` attribute | |||
|
|
|||
| </auro-accordion> | |||
|
|
|||
| #### Menu with pre-selected menu option | |||
| #### `selected` | |||
There was a problem hiding this comment.
Suggested change
| #### `selected` | |
| #### selected |
The backticks in headers is an old style we tried and backed away from. Still lingers in a few places but we need to stop using it in headers.
|
|
||
| The `auro-menu` element supports a pre-selected option via the `selected` attribute on the `auro-menuoption` element. | ||
| Use the `selected` attribute to pre-select an option or highlight a specific `auro-menuoption` in the `auro-menu`. |
There was a problem hiding this comment.
This confuses me a little that there is an "or" in this. selected does one specific thing. There is no highlighting an option with these styles that is not selected.
Suggested change
| Use the `selected` attribute to pre-select an option or highlight a specific `auro-menuoption` in the `auro-menu`. | |
| Use the `selected` attribute to pre-select an `auro-menuoption`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #169
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Update
selectedexample to talk about how it can be used to highlight an optionType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team