Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

代码 review 问题优化 #22

Closed
benbaley opened this issue Jun 11, 2021 · 1 comment
Closed

代码 review 问题优化 #22

benbaley opened this issue Jun 11, 2021 · 1 comment

Comments

@benbaley
Copy link
Collaborator

  1. 统一使用Staking做为质押的名字,Pledge统一改为Staking改过来
  2. RestrictingInfo.StakingAmount 名字有歧义(此字段包含质押和委托总金额),PledgeLockFunds函数同样包含质押和委托 都改为 AdvanceLockedFunds (预支金额)
  3. ApplyTransaction函数中出现result.Err != nil重复判断,需要去掉
  4. tx_cacher.go文件中存在大量注释方法,需要去掉
  5. 项目中“add by PlatON”注释需要全部去掉
  6. 检查经济模型的参数,有没有改动的单元测试
  7. cdfundBalance的余额的注释错误,需更正
  8. params.MainnetGenesisHash值需要更新, 另外需要补充验证创世区块hash的UT TestDefaultGenesisBlock(参考eth)
  9. ReceiptForStorage结构的rlp解码函数去掉V3版本的适配,同时去掉v3StoredReceiptRLP结构体
  10. 由于新增锁仓计划时的每个周期金额都已校验,因此新增计划的总金额的无需校验,需移除
  11. CalcGasLimit函数中去掉无用的注释
@benbaley benbaley changed the title 代码 代码 review 问题优化 Jun 11, 2021
@benbaley
Copy link
Collaborator Author

close by done

benbaley pushed a commit that referenced this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant