This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Proposed Verdicts collection #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albert221
suggested changes
Dec 7, 2017
| } | ||
|
|
||
| return true; | ||
| return count($this->verdicts->failing()) === 0; |
There was a problem hiding this comment.
1: Literals should be on the left side of an expression, for the sake of redability.
| $name | ||
| )); | ||
| } | ||
|
|
||
| return true; | ||
| return $verdictsForField->failing()->count === 0; |
| use Countable; | ||
| use IteratorAggregate; | ||
|
|
||
| class Verdicts implements Countable, IteratorAggregate |
| return new static(array_filter($this->verdicts, $function)); | ||
| } | ||
|
|
||
| public function reduce(callable $function, $initial = null) |
Albert221
reviewed
Dec 7, 2017
| return $this->verdicts; | ||
| } | ||
|
|
||
| public function /* Countable */ count(): int |
There was a problem hiding this comment.
I don't know, but is this PSR-2 compliant to have a comment here?
|
Besides those issues, I personally don't like the name Also, I'd like to change |
|
Closing as the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.