Fix scale mean formula when one axis is flipped #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D8H
changed the title
Alchemist0823
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Hi @D8H,
Thanks for the pull request and contribution. this makes sense. can you fix the / 3 on TrailBatch
src/TrailBatch.ts
Outdated
| @@ -246,8 +246,9 @@ export class TrailBatch extends VFXBatch { | |||
| this.widthBuffer.setX(index, current.size); | |||
| this.widthBuffer.setX(index + 1, current.size); | |||
| } else { | |||
| this.widthBuffer.setX(index, (current.size * (scale.x + scale.y + scale.z)) / 3); | |||
| this.widthBuffer.setX(index + 1, (current.size * (scale.x + scale.y + scale.z)) / 3); | |||
| const objectScale = Math.abs(scale.x) + Math.abs(scale.y) + Math.abs(scale.z); | |||
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm maintaining an extension for GDevelop that uses three.quarks.
https://wiki.gdevelop.io/gdevelop5/extensions/particle-emitter3d/
GDevelop flips the Y axis to be consistent with its 2D rendering. Because of this, the scale is negative on one axis and the sum is 1 instead of 3. It results in particles being 3 times smaller than expected.
I guess that using absolute scale values should fix the issue.