Deprecate passing a Page into PublishPageJob

Passing an page "object" here through `GlobalID` and then reloading will lead to double page loads.
AlchemyCMS · Apr 27, 2022 · ac8555f · ac8555f
1 parent c22e840
commit ac8555f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/jobs/alchemy/publish_page_job.rb b/app/jobs/alchemy/publish_page_job.rb
@@ -4,15 +4,15 @@ module Alchemy
   class PublishPageJob < BaseJob
     queue_as :default
 
-    def perform(page, public_on:)
+    def perform(page_id, public_on:)
       page = Alchemy::Page.includes(
         draft_version: {
           elements: [
             { ingredients: :related_object },
             { contents: :essence },
           ],
         },
-      ).find(page.id)
+      ).find(page_id)
       Alchemy::Page::Publisher.new(page).publish!(public_on: public_on)
     end
   end

diff --git a/app/models/alchemy/page.rb b/app/models/alchemy/page.rb
@@ -465,7 +465,7 @@ def copy_children_to(new_parent)
     #
     def publish!(current_time = Time.current)
       update(published_at: current_time)
-      PublishPageJob.perform_later(self, public_on: current_time)
+      PublishPageJob.perform_later(id, public_on: current_time)
     end
 
     # Sets the public_on date on the published version

diff --git a/spec/jobs/alchemy/publish_page_job_spec.rb b/spec/jobs/alchemy/publish_page_job_spec.rb
@@ -9,15 +9,15 @@
 
     it "enqueues job" do
       expect {
-        described_class.perform_later(page, public_on: public_on)
+        described_class.perform_later(page.id, public_on: public_on)
       }.to have_enqueued_job
     end
 
     it "calls the page publisher" do
       expect_any_instance_of(Alchemy::Page::Publisher).to receive(:publish!).with(
         public_on: public_on,
       )
-      described_class.new.perform(page, public_on: public_on)
+      described_class.new.perform(page.id, public_on: public_on)
     end
   end
 end