Do not freeze common_search_filter_includes

That way we can add more custom filters to the search without overwriting the method
AlchemyCMS · Jul 17, 2020 · af6e054 · af6e054
1 parent 5c63658
commit af6e054
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/app/controllers/alchemy/admin/resources_controller.rb b/app/controllers/alchemy/admin/resources_controller.rb
@@ -148,15 +148,15 @@ def search_filter_params
 
       def common_search_filter_includes
         [
-          {q: [
+          { q: [
             resource_handler.search_field_name,
             :s,
-          ]},
+          ] },
           :tagged_with,
           :filter,
           :page,
           :per_page,
-        ].freeze
+        ]
       end
 
       def items_per_page

diff --git a/spec/controllers/alchemy/admin/resources_controller_spec.rb b/spec/controllers/alchemy/admin/resources_controller_spec.rb
@@ -149,4 +149,14 @@ def resource_handler
       end
     end
   end
+
+  describe "#common_search_filter_includes" do
+    before do
+      allow(controller).to receive(:alchemy_module) { { name: "events" } }
+    end
+
+    it "should not be frozen" do
+      expect(controller.send(:common_search_filter_includes)).to_not be_frozen
+    end
+  end
 end