Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EssencePage in contact forms #1640

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Use EssencePage in contact forms #1640

merged 3 commits into from
Oct 16, 2019

Commits on Oct 16, 2019

  1. Use depth value of page in pages_for_select helper 

    Using the level attribute leads to N+1 queries as this
actually counts the ancestors for each page.
    @tvdeyen
    tvdeyen committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    f9227d2 View commit details
    Browse the repository at this point in the history

  2. Add support for EssencePage in messages controller 

    The messages controller meant for contact form messages now also
supports the recently introduced EssencePage.
    @tvdeyen
    tvdeyen committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    001ab98 View commit details
    Browse the repository at this point in the history

  3. Try to harden the attachment feature spec 

    This specs fails every now and then. The exact same spec for the
essence picture assignment never fails. Lets try the same wait behavior
and cross the fingers.
    @tvdeyen
    tvdeyen committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    8e396e7 View commit details
    Browse the repository at this point in the history