Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fontawesome in production #1765

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix fontawesome in production #1765

merged 1 commit into from Mar 30, 2020

Conversation

mickenorlen
Copy link
Contributor

What is this pull request for?

Closes #1762

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

tvdeyen
tvdeyen reviewed Mar 27, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

We can now remove this variable as well.

@mickenorlen
Fix fontawesome in production
a1f3ef3 
Use asset_url in font-face
@mickenorlen mickenorlen changed the title Use asset_url in fontawesome font-face Fix fontawesome in production Mar 28, 2020
@tvdeyen tvdeyen merged commit 0aa9984 into AlchemyCMS:master Mar 30, 2020
@tvdeyen
Copy link
Member

tvdeyen commented Mar 30, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font awesome not working in production
2 participants
@mickenorlen @tvdeyen