Deprecate Page#visible attribute #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Alchemy 5 all page slugs will be visible in URLs of child pages all the time. Please use Menus and Tags instead to re-organize your pages if your page tree does not reflect the URL hierarchy.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
tvdeyen
commented
May 27, 2020
This task helps with upgrading the page tree to Alchemy 5. It moves all children of invisible pages to the first visible parent (or the language root page), so that they reflect the URL hierarchy.
tvdeyen
force-pushed
the
deprecate-page_visible
branch
from
b120ed7
to
2486ead
Compare
tvdeyen
force-pushed
the
deprecate-page_visible
branch
from
32bf2db
to
2486ead
Compare
This refactors the page tree restructuring to do so recursively rather than analyzing parents.
Recursive page tree restructuring
tvdeyen
added a commit
that referenced
this pull request
Jun 4, 2020
- Use apt update instead of apt-get in GH action [#1865](#1865) ([tvdeyen](https://github.com/tvdeyen)) - Use depth for page tree serializer root_or_leaf [#1864](#1864) ([tvdeyen](https://github.com/tvdeyen)) - Fix sitemap wrapper height [#1861](#1861) ([tvdeyen](https://github.com/tvdeyen)) - Do not return the root page with API responses. [#1860](#1860) ([tvdeyen](https://github.com/tvdeyen)) - Introduce page.url_path and use it for alchemyPageSelect [#1859](#1859) ([tvdeyen](https://github.com/tvdeyen)) - Update Urlname translation [#1857](#1857) ([tvdeyen](https://github.com/tvdeyen)) - Show url name in Page tree [#1856](#1856) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate Page#visible attribute [#1855](#1855) ([tvdeyen](https://github.com/tvdeyen)) - 4.6: Re-add `auto_logout_time` configuration option [#1852](#1852) ([mamhoff](https://github.com/mamhoff)) - Backport ContentEditor to 4.6, deprecate removed methods on `Alchemy::Content` [#1847](#1847) ([mamhoff](https://github.com/mamhoff)) - Deprecate auto_logout_time (4.6) [#1843](#1843) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate require_ssl (4.6) [#1842](#1842) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate url_nesting configuration (4.6) [#1841](#1841) ([tvdeyen](https://github.com/tvdeyen)) - Allow page visible toggle (4.6) [#1838](#1838) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Deprecate
Page#visiblePage slugs will be visible in URLs of child pages all the time in the future.
Please use Menus and Tags instead to re-organize your pages if your page tree does not reflect the URL hierarchy.
A rake task to help with the migration is available.
Checklist