Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redirect_to_public_child flag and feature #1910

Merged
merged 2 commits into from Jul 31, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 26, 2020

What is this pull request for?

Remove redirect_to_public_child flag and feature.
This has been deprecated in 5.0 and is not supported anymore.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 5.1 milestone Jul 26, 2020
@tvdeyen tvdeyen force-pushed the remove-redirect_to_public_child branch from d01c892 to 7573bea Compare July 26, 2020 21:49
This has been deprecated in 5.0 and is not supported anymore.
@tvdeyen tvdeyen force-pushed the remove-redirect_to_public_child branch from 7573bea to fd481e8 Compare July 26, 2020 21:52
Now that we do not have to take care of the public child redirect anymore we can move the rather simple logic into the controller again.
@tvdeyen tvdeyen requested a review from mamhoff July 27, 2020 08:06
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have a tiny nit regarding a method name, take or leave as you wish.

app/controllers/alchemy/pages_controller.rb Show resolved Hide resolved
@tvdeyen tvdeyen merged commit 87ec366 into AlchemyCMS:master Jul 31, 2020
@tvdeyen tvdeyen deleted the remove-redirect_to_public_child branch July 31, 2020 08:14
@tvdeyen tvdeyen linked an issue Jul 31, 2020 that may be closed by this pull request
@tvdeyen tvdeyen restored the remove-redirect_to_public_child branch November 24, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redirect_to_public_child
2 participants