Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #1917

Merged
merged 5 commits into from
Aug 26, 2020
Merged

Update documentation #1917

merged 5 commits into from
Aug 26, 2020

Conversation

dhughesbc
Copy link
Contributor

@dhughesbc dhughesbc commented Aug 3, 2020

What is this pull request for?

Updates comment in the main config file to clarify how to turn on and use the built in image cropping/resizing feature.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@aprexisgithub aprexisgithub mentioned this pull request Aug 3, 2020
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Maybe I ask to rebase with latest master branch, so that the CI build passes again and there is a small typo.

# Alchemy uses Dragonfly to render images. Settings for image rendering are specific to elements and are defined in elements.yml
#
# Example:
# -name: some_element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before name

Suggested change
# -name: some_element
# - name: some_element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏻

@tvdeyen tvdeyen merged commit f3f0d43 into AlchemyCMS:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants